fix(databases): describe regions as plain region codes - #236
Merged
Merged
Conversation
The create row described --region as aws-<aws-region>. Call it a region, as the rest of the platform docs do. Co-authored-by: Cursor <cursoragent@cursor.com>
The databases create flag help described regions as aws-<aws-region>, and the durable scheduler example passed --regions aws-us-east-1, although scheduler regions have always been plain codes. The API now publishes database region IDs as us-east-1 and still accepts the older form. Co-authored-by: Cursor <cursoragent@cursor.com>
subnetmarco
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI told users to type region IDs that name the provider behind Volcano.
databases create --regionhelp saidaws-<aws-region>, e.g. aws-us-east-1. It now reads "Database region, such as us-east-1".docs/databases.md: the command table shows--region <region>, and the example uses--region us-east-1.durable schedulers createhelp example passed--regions aws-us-east-1. Scheduler regions are function region codes, which have always been plain, so it now passesus-east-1.Merge order
Merge after Kong/volcano-hosting#1478 is deployed. That change makes the API publish
us-east-1for database regions and accept both forms. Before it, the API only acceptsaws-us-east-1for databases, so a user following the new help would get a 400.The unit-test fixtures and
tests/e2e/apidefault still useaws-us-east-1. Those are mock payloads and a staging default, and the API keeps accepting that form.Validation
go build ./...passes.go test ./internal/cmd/databases/... ./internal/cmd/durable/...passes.docs/.