Skip to content

fix(databases): describe regions as plain region codes #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
subnetmarco merged 2 commits into from
Sep 27, 2026
Merged

fix(databases): describe regions as plain region codes #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07f3a1f
docs(databases): drop the AWS region placeholder
subnetmarco Sep 26, 2026
7c94edf
fix(databases): describe regions as plain region codes
subnetmarco Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/databases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ it using its connection string.

| Operation | Command |
|---|---|
| Create | `volcano databases create <name> [--type …] [--region aws-<aws-region>] [--pg-version …]` |
| Create | `volcano databases create <name> [--type …] [--region <region>] [--pg-version …]` |
| List | `volcano databases list` |
| Get | `volcano databases get <name> [--show-connection-string]` |
| Delete | `volcano databases delete <name>` |
Expand Down Expand Up @@ -191,7 +191,7 @@ same way.
```bash
# Create a database (defaults to type volcano-db-xs)
volcano databases create app
volcano databases create app --type volcano-db-s --region aws-us-east-1
volcano databases create app --type volcano-db-s --region us-east-1

# Show the connection string
volcano databases get app --show-connection-string
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/databases/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func newCreateWithOptions(deps cliruntime.Deps, commandOpts createCommandOptions
})
},
}
cmd.Flags().StringVar(&region, "region", "", "Database region (aws-<aws-region>, e.g. aws-us-east-1)")
cmd.Flags().StringVar(&region, "region", "", "Database region, such as us-east-1")
cmd.Flags().StringVar(&pgVersion, "pg-version", "", "PostgreSQL version")
cmd.Flags().StringVar(&databaseType, "type", "", "Database type (default: volcano-db-xs)")
cmd.Flags().BoolVar(&showConnectionString, "show-connection-string", false, "Show database connection string")
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/durable/schedulers/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ input every execution the scheduler starts receives.`,
%s`,
cliruntime.CommandPath(deps, `durable schedulers create order-pipeline --cron "0 * * * *"`),
cliruntime.CommandPath(deps, `durable schedulers create order-pipeline --name nightly-sweep --cron "0 2 * * *" --input sweep.json`),
cliruntime.CommandPath(deps, `durable schedulers create order-pipeline --cron "0 9 * * 1-5" --regions aws-us-east-1`)),
cliruntime.CommandPath(deps, `durable schedulers create order-pipeline --cron "0 9 * * 1-5" --regions us-east-1`)),
Args: cobra.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
opts.deps = deps
Expand Down
Loading