Skip to content

feat: add the metamask-extension base skill set #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrepimenta wants to merge 1 commit into
base: feat/base-skills-mobile
Choose a base branch
from
Open

feat: add the metamask-extension base skill set #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions domains/coding/skills/controller-guidelines/skill.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
name: controller-guidelines
description: BaseController development patterns
base: true
Comment on lines 2 to +4

@MajorLift MajorLift Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're only choosing one controller-related skill for extension it should probably be controller-integration(https://github.com/MetaMask/skills/blob/main/domains/coding/skills/controller-integration/repos/metamask-extension.md), since writing controllers is not a client-side concern, while integrating them comes up very frequently.

We can probably fit in both if wider understanding of controller internals seems valuable to have by default (or better yet have controller-integration reference sections of controller-guidelines so relevant information can be pulled by the agent as needed), but either way controller-integration would need to be included.

---
1 change: 1 addition & 0 deletions domains/performance/skills/perf-hooks-effects/skill.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
name: perf-hooks-effects
description: React hooks and effects optimization
base: true
---
1 change: 1 addition & 0 deletions domains/performance/skills/perf-react-compiler/skill.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
name: perf-react-compiler
description: React Compiler optimization patterns
base: true
---
1 change: 1 addition & 0 deletions domains/performance/skills/perf-rendering/skill.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
name: perf-rendering
description: Rendering performance optimization
base: true

@NicolasMassart NicolasMassart Aug 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: fix the perf trigger descriptions before making these base

The PR already calls out that the four perf-* descriptions are too thin to self-trigger.

That seems at odds with #135's rationale for the base-description guard: a base skill permanently consumes listing context, so installing one that rarely triggers gives us the cost without much benefit.

Could we either improve these descriptions in this PR before marking them base, or leave the perf skills opt-in until that cleanup is done?

---
1 change: 1 addition & 0 deletions domains/performance/skills/perf-state-management/skill.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
name: perf-state-management
description: Redux and state management optimization
base: true
---
1 change: 1 addition & 0 deletions domains/testing/skills/extension-testing/skill.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ description: >
the user mentions FixtureBuilderV2, page objects, E2E flake, POM anti-patterns,
MMQA testing-skills tickets, or asks which Extension testing skill to install.
maturity: stable
base: true
---

# Extension testing
Expand Down