Remove m_glContextInitialized, simplify updateScreen - #725
Conversation
|
Setting to draft while I investigate failure on master |
0c3f9d0 to
f72129b
Compare
|
@phkb @LW-archlinux I have rebased this with the fix (the revert) merged into master. Please let me know if it works for you. |
|
@oocube I saw you're commenting again. Please can you check this PR works for you. If this works but not #726, then I'll merge this otherwise I'll merge 726 instead as it is a superset of this.
|
|
I downloaded and tested Oolite-1.93.1-PullRequest725.3137-dev-x86_64.AppImage. While checking for the same things I did on the #726 build actually I could not make out any difference. Oolite-1.93.1-PullRequest725.3137-dev-x86_64.AppImage runs well - I did not observe any problems. Positioning and resizing is smooth. I also checked the fullscreen option, and switching it on and off does not cause any delays for me. Then I was wondering about the offered resolutions. I have two full HD screens (1920x1080) and one smaller (1680x1050) as the main screen. Oolite offers only resolutions fit for the smaller monitor, even if it runs on the other one. But it did not feel like this setting has any effect. Should it? |
|
Closing this in favour of #726 which is a superset |
@phkb @LW-archlinux If this works but not #726, then I'll merge this otherwise I'll merge 726 instead as it is a superset of this.