Even further simplify

[mcarans]

#725 +
move setUpBasicOpenGLStateWithSize from GameController.m to MyOpenGLVIew.m
make common updateGLSize function called by resize and initialiseGLwithSize
Move the related methods to be next to each other in the source for readability

@phkb @LW-archlinux If this works then I won't need to merge 725

[mcarans]

@phkb in addition can you try what's suggested here? https://discourse.libsdl.org/t/how-to-go-fullscreen-in-sdl3-without-ws-popup/69148/4 (ie. remove the Windows hack and instead hide the SDL window, call SDL_SetWindowFullscreen and show the window) then see if you get the 5 second delay when switching between window and fullscreen. Funnily enough this is the trick required to centre the game window after splash on Wayland on Linux.

SDL_HideWindow(window);
SDL_SetWindowFullscreen(window, fullScreen);
SDL_ShowWindow(window);

[mcarans]

Setting to draft while I investigate failure on master

[phkb]

The code in the PR is fine, tested OK, no pauses. However, attempting to remove the hack and do the hide/setWindowFullScreen/show thing still caused delays.

[mcarans]

The code in the PR is fine, tested OK, no pauses. However, attempting to remove the hack and do the hide/setWindowFullScreen/show thing still caused delays.

Thanks for testing. I have reported that hide/show didn't work: https://discourse.libsdl.org/t/how-to-go-fullscreen-in-sdl3-without-ws-popup/69148/5

I will have to rebase this PR assuming the fix I've made helps resolve Linux startup issues (#727)

[mcarans]

@phkb @LW-archlinux I have rebased this with the fix (the revert) merged into master. Please let me know if it works for you.

[mcarans]

@oocube I saw you're commenting again. Please can you check this PR works for you. If this works then I won't need to merge 725.

The flatpak failure is that the archive.mesa3d.org site used by a dependency that FlatHub demanded is temporarily down so please ignore for now. Flatpak build working now

[phkb]

Everything still looks OK from my end.

[oocube]

@oocube I saw you're commenting again. Please can you check this PR works for you. If this works then I won't need to merge 725.

The flatpak failure is that the archive.mesa3d.org site used by a dependency that FlatHub demanded is temporarily down so please ignore for now. Flatpak build working now

I checked https://github.com/OoliteProject/oolite/actions/runs/32767647793
It has the flatpak artifact only. What happened to the others?

Update: I checked the build logs and found the "Archive installer" step. In the end of the log there is a download url.

[oocube]

I downloaded Oolite-1.93.1-PullRequest726.3138-dev-x86_64.AppImage. It runs well - I did not observe any problems. Positioning and resizing is smooth.

For a first time I checked the fullscreen option, and switching it on and off does not cause any delays for me.
I was stunned where the fullscreen window goes, but apparently the game gets fullscreen on the screen it is running on when I turn on fullscreen. Absolutely ok for me.

Then I was wondering about the offered resolutions. I have two full HD screens (1920x1080) and one smaller (1680x1050) as the main screen. Oolite offers only resolutions fit for the smaller monitor, even if it runs on the other one. But it did not feel like this setting has any effect. Should it?

[LW-archlinux]

Both #725 and #726 work fine.

Sidenote:
galcop vipers get destroyed easily by a slow moving iron ass turreted ship .
Their AI doesn't seem to understand they should NOT close in to the target flying in straight line at max speed.

[mcarans]

Awesome this is such a good refactor!

[mcarans]

Oolite offers only resolutions fit for the smaller monitor, even if it runs on the other one. But it did not feel like this setting has any effect. Should it?

I'm not sure. I can see if there is an SDL3 thing for that.