annotation: split deltaGCSV into loadDeltaGCSV / saveDeltaGCSV - #719
Merged
Conversation
…sentinel filtering Fixes raven-gecko-parity#67. deltaGCSV(model, direction, ...) is replaced by two functions, matching raven_toolbox.annotation.load_delta_g_csv / save_delta_g_csv one-for-one instead of bundling both directions behind a direction string. No backward-compatible wrapper is kept -- the only call site in this repo (tAnnotation.m) is updated. loadDeltaGCSV also drops the missingValue argument deltaGCSV gained in #702/#705: rather than re-aligning defaults (which is what regressed raven-gecko-parity#16 the first time -- see that issue and raven-toolbox#102 for the history), every matched CSV value, including yeast-GEM's "no measurement" placeholder (10000000.0), is now always recorded literally, on both languages, with no default left to drift out of sync. saveDeltaGCSV correspondingly gains no sentinel-writing option: with load never turning a real value into an absent one, there is nothing for save to restore. Generated HTML docs under doc/ are not regenerated here (updateDocumentation() requires MATLAB) -- needs a doc rebuild before/after merge.
Function test results304 tests 277 ✅ 1m 5s ⏱️ Results for commit 1207f96. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deltaGCSV(model, direction, ...)with two functions,loadDeltaGCSVandsaveDeltaGCSV, matchingraven_toolbox.annotation.load_delta_g_csv/save_delta_g_csvone-for-one instead of bundling both directions behind adirectionstring. Fixes raven-gecko-parity#67.missingValuesentinel-filtering argument added in Add an optional missingValue argument to deltaGCSV #702/Default deltaGCSV missingValue to the yeast-GEM sentinel for parity #705. Every matched CSV value, including yeast-GEM's "no measurement" placeholder (10000000.0), is now always recorded literally on both languages, so there's no default left to drift out of sync (that drift is what caused raven-gecko-parity#16 the first time).tAnnotation.m.Generated HTML docs under
doc/are not regenerated here (updateDocumentation()needs MATLAB) — needs a doc rebuild before/after merge.Test plan
tAnnotation(deltaGCsvRoundTrip,loadDeltaGCsvStoresValuesLiterally) in MATLABupdateDocumentation()