remove: exportToTabDelimited, dead fallback in exportToExcelFormat - #727
Merged
Conversation
Found while auditing raven_toolbox port-gap issues (SysBioChalmers/raven-gecko-parity#55): exportToTabDelimited was reachable only from exportToExcelFormat's bare-path fallback, which silently switched output format depending on whether fileName looked like a path -- directly contradicting exportToExcelFormat's own error message ("only xlsx format is supported" as of RAVEN 1.9) for every other input. Removed the function, its one call site, and its test. Documented in docs/v3_review.md alongside the earlier followFluxes removal (#725).
edkerk
added a commit
to SysBioChalmers/raven-gecko-parity
that referenced
this pull request
Sep 4, 2026
SysBioChalmers/RAVEN#727 removes exportToTabDelimited and the dead exportToExcelFormat fallback that called it (not yet merged). Marked subsumed rather than python-pending in the meantime; the row will be deleted outright once that PR lands, the same treatment followFluxes got.
Function test results305 tests 278 ✅ 1m 21s ⏱️ Results for commit 619df18. |
edkerk
added a commit
to SysBioChalmers/raven-gecko-parity
that referenced
this pull request
Sep 4, 2026
SysBioChalmers/RAVEN#727 merged. Remove the now-stale row entirely (the function no longer exists in MATLAB either) and update exportToExcelFormat's notes to describe the fallback removal as done rather than pending.
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while auditing
raven_toolboxport-gap issues (SysBioChalmers/raven-gecko-parity#55):exportToTabDelimitedhad exactly one call site,exportToExcelFormat's bare-path fallback (if ~any(A) || ~any(B), whenfileNamehad no name/extension parts). That fallback silently switches output format depending on whetherfileNamelooks like a path — directly contradictingexportToExcelFormat's own error message for every other input ("As of RAVEN version 1.9, only export to xlsx format is supported").Removed:
io/exportToTabDelimited.m.io/exportToExcelFormat.m(now always writes.xlsx, or errors with the existing "only xlsx format is supported" message — the behaviour the docstring already claimed).tIO/exportToTabDelimitedWritesFiles.Documented in
docs/v3_review.md's "Already done in develop3" list, alongside the earlierfollowFluxesremoval (#725), which had been merged but not yet recorded there.Test plan
tIOtest class: 17/17 passed, includingexportToExcelFormatWritesFileandexportToExcelFormatWritesEcSheets(unaffected by the fallback removal)..mfile referencesexportToTabDelimited(only generateddoc/*.html, not hand-maintained).