web: Guard chiplet orientation test lookup

[jhkim-pii]

Coverity Defect Log

** CID 1687965:       Null pointer dereferences  (FORWARD_NULL)


_____________________________________________________________________________________________
*** CID 1687965:         Null pointer dereferences  (FORWARD_NULL)
/src/web/test/cpp/TestTileGenerator.cpp: 2172             in web::<unnamed>::TileGeneratorTest_TechResponseReportsTheFullOrientation_Test::TestBody()()
2166         if (entry.as_object().at("name").as_string() == die0->getName()) {
2167           die_entry = &entry.as_object();
2168           break;
2169         }
2170       }
2171       ASSERT_NE(die_entry, nullptr);
>>>     CID 1687965:         Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "die_entry" to "at", which dereferences it.
2172       EXPECT_EQ(die_entry->at("orient").as_string(), "MZ")
2173           << "the 3D orientation collapsed to its 2D half, losing the flip";
2174       EXPECT_TRUE(die_entry->at("mirror_z").as_bool());
2175     
2176       // layer_hierarchy carries it too: that is the tree the frontend walks when
2177       // it assigns z-indices.

Solution

CID	Defect type	Resolution
1687965	FORWARD_NULL	Fail and return before dereferencing missing chiplet or Backside hierarchy entries.

Related

• Causal PR: Web GUI: reflect chiplet orientation in the layout viewer #11429

[gemini-code-assist]

Code Review

This pull request replaces ASSERT_NE assertions with manual nullptr checks using ADD_FAILURE() and explicit returns in TestTileGenerator.cpp. The feedback suggests using the more idiomatic Google Test FAIL() macro instead, which automatically generates a fatal failure and returns from the function, simplifying the code.

[gemini-code-assist]

In Google Test, FAIL() is a fatal assertion macro that automatically generates a failure and returns from the current function. Using FAIL() is more concise and idiomatic than combining ADD_FAILURE() with an explicit return; statement.

  if (die_entry == nullptr) {
    FAIL() << "tech response has no chiplet " << die0->getName();
  }

[gemini-code-assist]

Similarly, FAIL() can be used here to simplify the fatal failure and return logic into a single idiomatic Google Test macro call.

  if (backside_node == nullptr) {
    FAIL() << "layer_hierarchy missing Backside category node";
  }