Skip to content

web: Guard chiplet orientation test lookup #11651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhkim-pii wants to merge 2 commits into
base: master
Choose a base branch
from
Open

web: Guard chiplet orientation test lookup #11651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7542b02
web: Guard chiplet orientation test lookup
jhkim-pii Oct 6, 2026
a60b398
web: Guard Backside category lookup
jhkim-pii Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/web/test/cpp/TestTileGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2168,7 +2168,10 @@ TEST_F(TileGeneratorTest, TechResponseReportsTheFullOrientation)
break;
}
}
ASSERT_NE(die_entry, nullptr);
if (die_entry == nullptr) {
ADD_FAILURE() << "tech response has no chiplet " << die0->getName();
return;
}
Comment on lines +2171 to +2174

@gemini-code-assist gemini-code-assist Bot Oct 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Google Test, FAIL() is a fatal assertion macro that automatically generates a failure and returns from the current function. Using FAIL() is more concise and idiomatic than combining ADD_FAILURE() with an explicit return; statement.

  if (die_entry == nullptr) {
    FAIL() << "tech response has no chiplet " << die0->getName();
  }

EXPECT_EQ(die_entry->at("orient").as_string(), "MZ")
<< "the 3D orientation collapsed to its 2D half, losing the flip";
EXPECT_TRUE(die_entry->at("mirror_z").as_bool());
Expand Down Expand Up @@ -4946,8 +4949,10 @@ TEST_F(TileGeneratorTest, LayerHierarchyBacksideCategory)
break;
}
}
ASSERT_NE(backside_node, nullptr)
<< "layer_hierarchy missing Backside category node";
if (backside_node == nullptr) {
ADD_FAILURE() << "layer_hierarchy missing Backside category node";
return;
}
Comment on lines +4952 to +4955

@gemini-code-assist gemini-code-assist Bot Oct 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similarly, FAIL() can be used here to simplify the fatal failure and return logic into a single idiomatic Google Test macro call.

  if (backside_node == nullptr) {
    FAIL() << "layer_hierarchy missing Backside category node";
  }

EXPECT_EQ(backside_node->at("type").as_string(), "category");

// The backside node should contain exactly metal1 and via1.
Expand Down
Loading