odb: create dbBTerm::getChipBump#9697
odb: create dbBTerm::getChipBump#9697osamahammad21 merged 3 commits intoThe-OpenROAD-Project:masterfrom
Conversation
To be able to get the dbChipBump from the bterm Signed-off-by: Ahmed R. Mohamed <ahmed@precisioninno.com>
ahmed532
force-pushed
the
feat/odb-dbTerm-dbChipBump
branch
from
a8170a9 to
d12ccd3
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new method dbBTerm::getChipBump() to provide a direct way to get the dbChipBump associated with a dbBTerm. This is achieved by adding a back-reference from dbBTerm to dbChipBump, which is populated when dbChipBump::setBTerm is called. The database schema has been updated accordingly. This new method is then used to refactor and simplify the logic in 3dblox.cpp, removing the need for manually building a port-to-bump map. The changes are well-implemented and improve code clarity. I have one minor suggestion to improve code quality.
Note: Security Review did not run due to the size of the PR.
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Ahmed R. Mohamed <ahmed@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
osamahammad21
left a comment
osamahammad21
left a comment
There was a problem hiding this comment.
Nice work, Could we add a test in Test3DBloxParser for this?
|
Sure, I'll add tests. |
Signed-off-by: Ahmed R. Mohamed <ahmed@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
osamahammad21
merged commit a5f58fc
into
The-OpenROAD-Project:master
…bTerm-dbChipBump odb: create dbBTerm::getChipBump
2 participants
To be able to get the dbChipBump from the bterm
Closes: #9626