GH-50739: [C++] Make simdjson required for static linking - #50741
Merged
Conversation
|
|
Unlike RapidJSON, simdjson is not header-only and needs to be linked to explicitly when linking against libarrow.a.
pitrou
force-pushed
the
gh50739-jni-simdjson
branch
from
July 30, 2026 12:44
b75991f to
a754a77
Compare
pitrou
marked this pull request as ready for review
July 30, 2026 15:09
pitrou
commented
Jul 30, 2026
Comment on lines
+64
to
+68
| if(ARROW_WITH_SIMDJSON) | ||
| if(simdjson_SOURCE STREQUAL "SYSTEM") | ||
| list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS simdjson::simdjson) | ||
| endif() | ||
| endif() |
Member
Author
There was a problem hiding this comment.
FTR, it would be nice if we didn't have to add these declarations separately for Arrow static lib dependencies. @raulcd
Member
There was a problem hiding this comment.
The best place would be to try and add something more automatic into resolve_dependency when using SYSTEM but target names are quite varied and sometimes not yet known when resolving the dependency, example ARROW_ZSTD_LIBZSTD. I'll open an issue maybe we can investigate further or try some things.
github-actions
Bot
added
awaiting committer review
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: a754a77 Submitted crossbow builds: ursacomputing/crossbow @ actions-14f6111fc5
|
github-actions
Bot
added
awaiting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Unlike RapidJSON, simdjson is not header-only and needs to be linked to explicitly when linking against libarrow.a.
This should fix the JNI builds on the C++ Extra workflow.
Are these changes tested?
Yes, by existing CI builds.
Are there any user-facing changes?
No.