Skip to content

GH-50739: [C++] Make simdjson required for static linking #50741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 1 commit into from
Jul 31, 2026
+7 −3
Merged

GH-50739: [C++] Make simdjson required for static linking #50741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2851,9 +2851,7 @@ if(ARROW_WITH_SIMDJSON)
FORCE_ANY_NEWER_VERSION
TRUE
REQUIRED_VERSION
${ARROW_SIMDJSON_REQUIRED_VERSION}
IS_RUNTIME_DEPENDENCY
FALSE)
${ARROW_SIMDJSON_REQUIRED_VERSION})
if(SIMDJSON_VENDORED)
add_library(arrow::simdjson ALIAS simdjson)
else()
Expand Down
6 changes: 6 additions & 0 deletions cpp/src/arrow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ if(ARROW_WITH_LZ4)
endif()
endif()

if(ARROW_WITH_SIMDJSON)
if(simdjson_SOURCE STREQUAL "SYSTEM")
list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS simdjson::simdjson)
endif()
endif()
Comment on lines +64 to +68

@pitrou pitrou Jul 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, it would be nice if we didn't have to add these declarations separately for Arrow static lib dependencies. @raulcd

@raulcd raulcd Jul 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best place would be to try and add something more automatic into resolve_dependency when using SYSTEM but target names are quite varied and sometimes not yet known when resolving the dependency, example ARROW_ZSTD_LIBZSTD. I'll open an issue maybe we can investigate further or try some things.

@raulcd raulcd Jul 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #50753


if(ARROW_WITH_SNAPPY)
if(Snappy_SOURCE STREQUAL "SYSTEM")
list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${Snappy_TARGET})
Expand Down
Loading