bug: Add test verifying a bug in AshSql with has_many with limit and sort not respected in exists query filters#667
Merged
zachdaniel merged 1 commit intomainfrom Jan 29, 2026
Conversation
…and `sort` not respected in `exists` query filters
sevenseacat
added a commit
to ash-project/ash_sql
that referenced
this pull request
Dec 26, 2025
…ry filters Previously, the relationship limit was not being applied when using the relationship in an `exists` query. After fixing that, then the limit was being applied in the wrong place - it needs to be *inside* the exists check pre-filtering, instead of outside it. The test for this feature is in AshPostgres ash-project/ash_postgres#667 - this code makes that test pass.
Merged
7 tasks
zachdaniel
reviewed
Dec 26, 2025
| relationship_context: %{data_layer: %{table: "comment_ratings"}} | ||
| ) | ||
|
|
||
| has_many :top_ratings, AshPostgres.Test.Rating do |
Contributor
There was a problem hiding this comment.
Given the solution in ash_sql, would it be possible to add and test a relationship here that also has a parent/1 expression in its filter?
Contributor
Author
There was a problem hiding this comment.
that's another issue I haven't quite managed to figure out, parents and exists seem to be a bit weird, filters in the wrong places
zachdaniel
pushed a commit
to ash-project/ash_sql
that referenced
this pull request
Jan 29, 2026
…ry filters (#198) Previously, the relationship limit was not being applied when using the relationship in an `exists` query. After fixing that, then the limit was being applied in the wrong place - it needs to be *inside* the exists check pre-filtering, instead of outside it. The test for this feature is in AshPostgres ash-project/ash_postgres#667 - this code makes that test pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test currently fails, and the fix is in ash-project/ash_sql#198 :)
Contributor checklist
Leave anything that you believe does not apply unchecked.