fix: has_many with limit and sort not respected in exists query filters#198
Merged
zachdaniel merged 1 commit intomainfrom Jan 29, 2026
Merged
fix: has_many with limit and sort not respected in exists query filters#198zachdaniel merged 1 commit intomainfrom
has_many with limit and sort not respected in exists query filters#198zachdaniel merged 1 commit intomainfrom
Conversation
…ry filters Previously, the relationship limit was not being applied when using the relationship in an `exists` query. After fixing that, then the limit was being applied in the wrong place - it needs to be *inside* the exists check pre-filtering, instead of outside it. The test for this feature is in AshPostgres ash-project/ash_postgres#667 - this code makes that test pass.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the relationship limit was not being applied when using the relationship in an
existsquery. After fixing that, then the limit was being applied in the wrong place - it needs to be inside the exists check pre-filtering, instead of outside it.The test for this feature is in AshPostgres, as AshSql doesn't have its own test suite ash-project/ash_postgres#667 - this code makes that test pass.
(Claude wrote this code and I thoroughly tested it to the level that I'm comfortable putting my name on it)
Dialyzer failure is pre-existing and currently fails on main.
Contributor checklist
Leave anything that you believe does not apply unchecked.