Repository navigation
Declare HTTP client deps explicitly - #7426
Merged
Merged
Conversation
In parallel builds (e.g. -T0.4C), service-client-backward-compat-test
can fail to build because a dependency in its closure is missing. In
this case, the HTTP clients. The s3:2.28.1 module inherits a dependency
on netty-nio-client which is literally ${awsjavasdk.version}. However,
because it also imports the bom which is using the current project
version (not 2.28.1), that version becomes the current project version,
instead of the expected 2.28.1. Because that ${awsjavasdk.version}
version comes from through the bom and not in the <dependencies> block,
Maven doesn't order the builds correctly and the build of this module
can fail with dependency not found.
dagnir
force-pushed
the
dongie/fix-backcompat-build
branch
from
October 6, 2026 20:32
1e17cd4 to
d8b682a
Compare
S-Saranya1
approved these changes
Oct 6, 2026
dagnir
enabled auto-merge
October 6, 2026 21:00
7 of 12 tasks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 7, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In parallel builds (e.g. -T0.4C), service-client-backward-compat-test can fail to build because a dependency in its closure is missing. In this case, the HTTP clients. The s3:2.28.1 module inherits a dependency on netty-nio-client which is literally ${awsjavasdk.version}. However, because it also imports the bom which is using the current project version (not 2.28.1), that version becomes the current project version, instead of the expected 2.28.1. Because that ${awsjavasdk.version} version comes from through the bom and not in the block, Maven doesn't order the builds correctly and the build of this module can fail with dependency not found.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License