Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix process pipe deadlock in Docker Prune#236

Merged
acebytes merged 1 commit into
mainfrom
sentinel/fix-docker-prune-deadlock-16943645145989401678
May 17, 2026
Merged

πŸ›‘οΈ Sentinel: [MEDIUM] Fix process pipe deadlock in Docker Prune#236
acebytes merged 1 commit into
mainfrom
sentinel/fix-docker-prune-deadlock-16943645145989401678

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

  • 🚨 Severity: MEDIUM
  • πŸ’‘ Vulnerability: process.waitUntilExit() is called before reading from the output pipe. If the process output exceeds the macOS pipe buffer (~64KB), the child process will block writing, and the parent will block waiting, causing a deadlock.
  • 🎯 Impact: An attacker or a verbose Docker output could cause the application to hang indefinitely.
  • πŸ”§ Fix: Read the pipe data concurrently or before waitUntilExit() using try pipe.fileHandleForReading.readToEnd() ?? Data().
  • βœ… Verification: Run docker system prune and observe that the app successfully captures the output without freezing, even with large logs.

PR created automatically by Jules for task 16943645145989401678 started by @acebytes

@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Read the pipe using `readToEnd()` before calling `waitUntilExit()` in `dockerPrune` to prevent the application from hanging if Docker output exceeds the 64KB pipe buffer size.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@acebytes acebytes force-pushed the sentinel/fix-docker-prune-deadlock-16943645145989401678 branch from 47a99e5 to e572ec6 Compare May 17, 2026 14:37
@acebytes acebytes merged commit 7e2c14e into main May 17, 2026
1 check passed
@acebytes acebytes deleted the sentinel/fix-docker-prune-deadlock-16943645145989401678 branch May 17, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant