π‘οΈ Sentinel: [MEDIUM] Fix process pipe deadlock in Docker Prune#236
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Read the pipe using `readToEnd()` before calling `waitUntilExit()` in `dockerPrune` to prevent the application from hanging if Docker output exceeds the 64KB pipe buffer size. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
47a99e5 to
e572ec6
Compare
process.waitUntilExit()is called before reading from the output pipe. If the process output exceeds the macOS pipe buffer (~64KB), the child process will block writing, and the parent will block waiting, causing a deadlock.waitUntilExit()usingtry pipe.fileHandleForReading.readToEnd() ?? Data().docker system pruneand observe that the app successfully captures the output without freezing, even with large logs.PR created automatically by Jules for task 16943645145989401678 started by @acebytes