Skip to content

fix(extension): keep companion content scripts self-contained#5499

Merged
rebelchris merged 2 commits intomainfrom
eng-719-companion-app-not-loading
Feb 17, 2026
Merged

fix(extension): keep companion content scripts self-contained#5499
rebelchris merged 2 commits intomainfrom
eng-719-companion-app-not-loading

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

@rebelchris rebelchris commented Feb 17, 2026

Summary

  • fix companion content script stylesheet reference from css/daily-companion-app.css to css/companion.css
  • keep content/companion/manifest bundles self-contained by excluding them from chunk splitting
  • preserve runtime/split chunk optimization for newtab only

Key decisions

  • content scripts now avoid shared runtime/split chunks because dynamically registered scripts must reference standalone files
  • optimization remains enabled for newtab to keep the original bundle-size protection in place

Closes ENG-719


Created by Huginn 🐦‍⬛

Preview domain

https://eng-719-companion-app-not-loadin.preview.app.daily.dev

@rebelchris rebelchris requested a review from a team as a code owner February 17, 2026 04:07
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Feb 17, 2026 4:11am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Feb 17, 2026 4:11am

Request Review

@rebelchris rebelchris merged commit 72497b8 into main Feb 17, 2026
11 checks passed
@rebelchris rebelchris deleted the eng-719-companion-app-not-loading branch February 17, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant