Skip to content

fix(extension): keep companion content scripts self-contained #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebelchris merged 2 commits into from
Feb 17, 2026
Merged

fix(extension): keep companion content scripts self-contained #5499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35af6e2
fix(extension): keep companion content scripts self-contained
rebelchris Feb 17, 2026
78538d3
fix(extension): preserve newtab split-chunk optimization
rebelchris Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/extension/src/lib/extensionScripts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const registerBrowserContentScripts = async (): Promise<void> => {
// TODO: this needs to be switched to browser.scripting when bumping FF to V3 as well
await browser.contentScripts.register({
matches: ['*://*/*'],
css: [{ file: 'css/daily-companion-app.css' }],
css: [{ file: 'css/companion.css' }],
js: [
{ file: 'js/content.bundle.js' },
{ file: 'js/companion.bundle.js' },
Expand All @@ -50,7 +50,7 @@ export const registerBrowserContentScripts = async (): Promise<void> => {
{
id: companionScriptId,
matches: ['*://*/*'],
css: ['css/daily-companion-app.css'],
css: ['css/companion.css'],
js: ['js/content.bundle.js', 'js/companion.bundle.js'],
},
]);
Expand Down
14 changes: 10 additions & 4 deletions packages/extension/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,17 @@ const mainConfig = {
],
optimization: {
...baseConfig.optimization,
// Enable runtime chunk to reduce individual bundle sizes
runtimeChunk: 'single',
// Split chunks to reduce newtab bundle size and avoid "Invalid array length" errors
// Only extract runtime for newtab; content scripts must stay self-contained
runtimeChunk: {
name(entrypoint) {
return entrypoint.name === 'newtab' ? 'runtime' : false;
},
},
// Only split newtab chunks; content scripts must remain single bundles
splitChunks: {
chunks: 'all',
chunks(chunk) {
return !['content', 'companion', 'manifest'].includes(chunk.name);
},
maxSize: 244000, // ~238KB max chunk size to avoid V8 limits
cacheGroups: {
defaultVendors: {
Expand Down