Upgrade coincurve versioning to allow 21.x#47
Conversation
|
Thanks! Unfortunately CI is now failing on Coincurve installation: |
|
I can make CI pass if you want but how long do you plan to support 3.8? |
|
I don't think this is related to 3.8. It also fails on the 3.10 job, and i suspect it would fail on all of them given enough time. |
|
I think I found the issue, can you please run CI once more? The Python packaging ecosystem has standardized on the interface for build backends (PEP 517/PEP 660) and the format for metadata declaration (PEP 621/PEP 631). As a result, the execution of setup.py files is now deprecated. |
|
Unfortunate that the CI doesn't run automatically anymore, just kicked it let's see. |
|
Yay all green now! |
|
Hi, just letting you know i did not forget about this. |
|
bump :) |
|
Please merge and make a new release on PyPI, this is making the library unusable with modern python versions. If you are not able to merge in time (it's been 8 months since the coincurve 21.x release), maybe just let's just drop the upper bound, so we do not hit the same issue again next time coincurve is updated. |
|
Fair enough, i'll get to it and i think i'll also drop the upper bound.
…-------- Original Message --------
On Thursday, 11/06/25 at 08:26 Pavol Rusnak ***@***.***> wrote:
prusnak left a comment [(darosior/python-bip32#47)](#47 (comment))
Please merge and make a new release on PyPI, this is making the library unusable with modern python versions.
If you are not able to merge in time (it's been 8 months since the coincurve 21.x release), maybe just let's just drop the upper bound, so we do not hit the same issue again.
—
Reply to this email directly, [view it on GitHub](#47 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F62UWMUEASKDEFPBSL33ND6PAVCNFSM6AAAAABYTFK36OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOJXGI2TINRRGU).
You are receiving this because you commented.Message ID: ***@***.***>
|
that would be awesome! coincurve are bumping their major version aggressively even though there are no API breaking changes so this makes sense. |
|
I cherry-picked your second commit in a PR dedicated to properly move the project away from our deprecated ways: #49. I plan to make a first release for the project structure change, followed by merging the Coincurve version bump and a second release. |
Thanks to Ofek Lev for the original PR to upgrade to the latest Coincurve: #47 Co-Authored-By: Ofek Lev <[email protected]>
|
I have a separate PR which supersedes this one to upgrade to Coincurve. Unfortunately it seems to fail CI because of ofek/coincurve#187 at the moment. I'll get a release PR together to be ready to publish a new release as soon as it's resolved. |
Thanks to Ofek Lev for the original PR to upgrade to the latest Coincurve: #47 Co-Authored-By: Ofek Lev <[email protected]>
|
hey @darosior can i help you in any weay to make this happen? |
|
Hey @dni unfortunately we are blocked on coincurve making a release. I tried to circle back 2 weeks ago (ofek/coincurve#187 (comment)), but no luck so far. Maybe try helping with the release there? |
This upgrades
coincurveto v21.0.0 which brings performance improvements and removes all runtime dependencies!