test: narrow BlockchainIdentities routing test to exact shared-path variant#556
Merged
lklimek merged 2 commits intofeat/blockchain-identities-account-typefrom Mar 16, 2026
Merged
Conversation
6 tasks
…160 shared-path variant Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on BlockchainIdentities account type implementation
test: narrow BlockchainIdentities routing test to exact shared-path variant
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_normal_payment_to_identity_address_not_detectedhad two problems: its name contradicted the actual expected behavior (payment is detected), and it accepted anyBlockchainIdentities*variant, which would pass even if routing hit the wrong account type.Changes
test_normal_payment_to_identity_registration_shared_path_detected_via_blockchain_identities_ecdsa_hash160BlockchainIdentities*variants to exclusivelyBlockchainIdentitiesECDSAHash160— the only variant that actually shares them/9'/coinType'/5'/1'derivation path (subfeature=1) with identity registration💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.