Skip to content

test: narrow BlockchainIdentities routing test to exact shared-path variant #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lklimek merged 2 commits into from
Mar 16, 2026
+10 −11
Merged

test: narrow BlockchainIdentities routing test to exact shared-path variant #556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98c54ad
Initial plan
Copilot Mar 16, 2026
d3782c2
test: rename and narrow BlockchainIdentities test to exact ECDSA_HASH…
Copilot Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions key-wallet/src/transaction_checking/transaction_router/tests/identity_transactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ async fn test_identity_registration_account_routing() {
}

#[tokio::test]
async fn test_normal_payment_to_identity_address_not_detected() {
async fn test_normal_payment_to_identity_registration_shared_path_detected_via_blockchain_identities_ecdsa_hash160(
) {
let network = Network::Testnet;

let mut wallet = Wallet::new_random(network, WalletAccountCreationOptions::Default)
Expand Down Expand Up @@ -229,12 +230,12 @@ async fn test_normal_payment_to_identity_address_not_detected() {
.await;

// The identity registration address (m/9'/coinType'/5'/1') is shared with
// BlockchainIdentities subfeature=1. Since BlockchainIdentities accounts are
// checked for standard transactions, this normal payment IS now detected
// via the BlockchainIdentities account (but NOT via IdentityRegistration).
// BlockchainIdentitiesECDSAHash160 (subfeature=1). Since BlockchainIdentities accounts are
// checked for standard transactions, this normal payment IS detected
// via BlockchainIdentitiesECDSAHash160 (but NOT via IdentityRegistration).
assert!(
result.is_relevant,
"Normal payment to identity-path address should be detected via BlockchainIdentities"
"Normal payment to identity-path address should be detected via BlockchainIdentitiesECDSAHash160"
);

// Verify that identity registration account is NOT in the affected accounts
Expand All @@ -247,16 +248,14 @@ async fn test_normal_payment_to_identity_address_not_detected() {
"Identity registration account should not be affected by normal payment"
);

// But BlockchainIdentities should be in the affected accounts
// Specifically BlockchainIdentitiesECDSAHash160 (subfeature=1) should be in the affected
// accounts, as it shares the m/9'/coinType'/5'/1' derivation path with identity registration
assert!(
result.affected_accounts.iter().any(|acc| matches!(
acc.account_type_match.to_account_type_to_check(),
AccountTypeToCheck::BlockchainIdentitiesECDSA
| AccountTypeToCheck::BlockchainIdentitiesECDSAHash160
| AccountTypeToCheck::BlockchainIdentitiesBLS
| AccountTypeToCheck::BlockchainIdentitiesBLSHash160
AccountTypeToCheck::BlockchainIdentitiesECDSAHash160
)),
"BlockchainIdentities account should be affected by normal payment to shared-path address"
"BlockchainIdentitiesECDSAHash160 account should be affected by normal payment to the shared m/9'/coinType'/5'/1' path"
);
}

Expand Down