acc: make $TESTDIR use forward slashes on all platforms - #6310
Merged
Conversation
Collaborator
Integration test reportCommit: 029ae23
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 6 slowest tests (at least 2 minutes):
|
Normalize the TESTDIR env var with filepath.ToSlash so paths built from it (e.g. the diff.py invocation echoed in trace output) are stable across OSes. Previously TESTDIR carried Windows backslashes, so a test echoing it needed a per-test `\\`->`/` replacement in test.toml. Remove that now-redundant replacement from default-sql-catalog-dash, whose only purpose was normalizing the TESTDIR path. Other backslash replacements in the suite address paths emitted by the CLI itself and stay. Follow-up to review feedback on #6293. Co-authored-by: Isaac
pavloKozlov
force-pushed
the
acc-testdir-forward-slashes
branch
from
August 18, 2026 14:32
42b85b1 to
029ae23
Compare
andrewnester
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Normalize the
TESTDIRenv var in the acceptance harness withfilepath.ToSlash, so paths built from$TESTDIR(e.g. thediff.pyinvocation echoed intraceoutput) use forward slashes on every OS.The other backslash replacements across the suite address paths emitted by the CLI itself (bundle roots, sync paths, artifact globs) and are left in place.
Why
Follow-up to review feedback from @denik on #6293: rather than papering over the Windows backslashes with a per-test replacement, fix it at the source where the path is produced. This matches the repo rule "Always output file paths with forward slashes, even on Windows. Use
filepath.ToSlash."The
[TESTROOT]replacement already registers both slash forms on Windows (SetPathNoEval), so the forward-slashTESTDIRprefix is still collapsed to[TESTROOT]— no golden changes.