Skip to content

acc: make $TESTDIR use forward slashes on all platforms #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavloKozlov merged 1 commit into from
Aug 18, 2026
Merged

acc: make $TESTDIR use forward slashes on all platforms #6310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion acceptance/acceptance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,9 @@ func runTest(t *testing.T,

absDir, err := filepath.Abs(dir)
require.NoError(t, err)
cmd.Env = append(cmd.Env, "TESTDIR="+absDir)
// Use forward slashes so paths built from $TESTDIR (e.g. echoed in trace
// output) are stable across OSes and don't need per-test slash replacements.
cmd.Env = append(cmd.Env, "TESTDIR="+filepath.ToSlash(absDir))
cmd.Env = append(cmd.Env, "CLOUD_ENV="+cloudEnv)
cmd.Env = append(cmd.Env, "CURRENT_USER_NAME="+user.UserName)
if !isRunningOnCloud {
Expand Down
5 changes: 0 additions & 5 deletions acceptance/bundle/templates/default-sql-catalog-dash/test.toml
View file
Open in desktop

This file was deleted.

Loading