Skip to content

Remove dynamic enabling now obsolete use_v2_api feature flag.#6396

Merged
nick-nlb merged 5 commits into
datacommonsorg:masterfrom
nick-nlb:flag-removal-final-use-v2-api
Jun 22, 2026
Merged

Remove dynamic enabling now obsolete use_v2_api feature flag.#6396
nick-nlb merged 5 commits into
datacommonsorg:masterfrom
nick-nlb:flag-removal-final-use-v2-api

Conversation

@nick-nlb

Copy link
Copy Markdown
Contributor

Goal

Remove dynamic enabling of the obsolete use_v2_api feature flag from the CDC services startup script, aligning with the deprecation and removal of v1 API paths.

Description

The use_v2_api flag has already been removed from usage within website (frontend/Flask). This PR follows that with a removal of the final reference to that flag in the CDC services startup script. We will follow this with a removal of the flags themselves.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the CDC services startup process by removing the dynamic enabling of the deprecated use_v2_api feature flag. This change aligns the startup configuration with the broader effort to deprecate v1 API paths, ensuring that only the relevant enable_nl_v2node_fetchall flag is managed dynamically.

Highlights

  • Removal of obsolete feature flag: Removed the use_v2_api feature flag logic from the CDC services startup script.
  • Script cleanup: Updated the Python snippet within the shell script to focus exclusively on enabling enable_nl_v2node_fetchall.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the dynamic enabling of the use_v2_api feature flag in custom.json within the run.sh script, leaving only the enable_nl_v2node_fetchall flag to be enabled. Feedback suggests making the warning log message more specific by explicitly mentioning the enable_nl_v2node_fetchall flag instead of using a generic message.

Comment thread build/cdc_services/run.sh Outdated
@nick-nlb nick-nlb requested review from clincoln8 and gmechali June 18, 2026 16:44
@clincoln8

Copy link
Copy Markdown
Contributor

@clincoln8 clincoln8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@nick-nlb nick-nlb merged commit 2d88069 into datacommonsorg:master Jun 22, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants