Remove dynamic enabling now obsolete use_v2_api feature flag.#6396
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cleans up the CDC services startup process by removing the dynamic enabling of the deprecated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the dynamic enabling of the use_v2_api feature flag in custom.json within the run.sh script, leaving only the enable_nl_v2node_fetchall flag to be enabled. Feedback suggests making the warning log message more specific by explicitly mentioning the enable_nl_v2node_fetchall flag instead of using a generic message.
Goal
Remove dynamic enabling of the obsolete
use_v2_apifeature flag from the CDC services startup script, aligning with the deprecation and removal ofv1API paths.Description
The
use_v2_apiflag has already been removed from usage within website (frontend/Flask). This PR follows that with a removal of the final reference to that flag in the CDC services startup script. We will follow this with a removal of the flags themselves.