fix: fire signup_submitted when email verification is off#98
Merged
Conversation
TrackOnMount(signup_submitted) only rendered on the "Check your email" page, which requireVerification:false skips entirely -- that path redirects straight to postRegisterStep's target, so the event never fired on any environment with EMAIL_VERIFICATION=false (staging). Confirmed live: a real password signup in staging showed no event between the /signup/password page hit and landing in onboarding. Key changes: - runEnumerationSafeRegister now calls trackServerEvent in its verification-not-required branch, mirroring the existing IdP call and its rationale (browser never renders a page to track from) - Channel is 'password' or 'passkey' based on cfg.hasPassword, covering both registerWithPassword and registerPasskeyFirst since they share this function
Contributor
🧪 Test Summary
|
mattdjenkinson
enabled auto-merge
July 16, 2026 21:15
kevwilliams
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Confirmed live in staging: a real password signup produced no
signup_submittedevent at all — the event log jumped straight from the/signup/passwordpage hit to landing in/onboarding/profile, with nothing in between.Root cause
TrackOnMount(signup_submitted)only renders on/signup/password's "Check your email" screen, which is the branch taken when email verification is required. Staging runs withEMAIL_VERIFICATION=false, so registration takes the other branch inrunEnumerationSafeRegisterand redirects straight topostRegisterStep's target — the browser never renders a page that could fire the client-side event.Changes
runEnumerationSafeRegister's verification-not-required branch now callstrackServerEvent('signup_submitted', ...)directly, mirroring the existing IdP call in this same file and its rationale (the browser never renders a trackable page). Channel is'password'or'passkey'based oncfg.hasPassword, since bothregisterWithPasswordandregisterPasskeyFirstshare this function.Typecheck, lint, and prettier all pass. No existing unit tests cover
signup.service.ts(it has zero prior coverage), and the outbound call is a server-sidefetch()that Cypress's browser-levelcy.intercept()can't observe, so this is verified live rather than via a new test harness.