Skip to content

fix: fire signup_submitted when email verification is off #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdjenkinson merged 1 commit into from
Jul 16, 2026
Merged

fix: fire signup_submitted when email verification is off #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/resources/signup/signup.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,13 @@ async function runEnumerationSafeRegister(
const sessions = await retryOnceIfNotFound(() => persistSession(user));
// Audit shape DIVERGES per path — parameterized, never collapsed to one event.
cfg.noVerifySuccessAudit(user);
// Fired server-side (not the client trackAuthEvent) because this path redirects the
// browser straight to postRegisterStep's target without ever rendering the
// "Check your email" page that carries the client-side TrackOnMount.
trackServerEvent('signup_submitted', {
userId: user.id,
properties: { channel: cfg.hasPassword ? 'password' : 'passkey' },
});
const target = postRegisterStep({
hasPassword: cfg.hasPassword,
emailVerified: false,
Expand Down
Loading