fix(sql_connect): queries are not single instanced for execute - #18500
fix(sql_connect): queries are not single instanced for execute#18500aashishpatil-g wants to merge 1 commit into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements query tracking in FirebaseDataConnect to ensure that identical queries return the same QueryRef instance. It updates QueryRef to clean up its _streamController reference when closed, stores newly created queries in _queryManager.trackedQueries, and adds a unit test to verify this caching behavior. There are no review comments, and I have no feedback to provide.
QueryRefs are not single instanced when calling execute so queryrefs get overwritten when first subscribe is called resulting in orphaned queryrefs created for execute.