Skip to content

fix(sql_connect): queries are not single instanced for execute #18500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aashishpatil-g wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sql_connect): queries are not single instanced for execute #18500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/firebase_data_connect/firebase_data_connect/lib/src/core/ref.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ class QueryRef<Data, Variables> extends OperationRef<Data, Variables> {
_serverStreamSubscription?.cancel();
_serverStreamSubscription = null;
_serverStream = null;
_streamController = null;
}

Stream<QueryResult<Data, Variables>> subscribe() {
Expand Down
4 changes: 3 additions & 1 deletion packages/firebase_data_connect/firebase_data_connect/lib/src/firebase_data_connect.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class FirebaseDataConnect extends FirebasePlugin {
if (ref != null) {
return ref;
} else {
return QueryRef<Data, Variables>(
final newRef = QueryRef<Data, Variables>(
this,
operationName,
transport!,
Expand All @@ -153,6 +153,8 @@ class FirebaseDataConnect extends FirebasePlugin {
varsSerializer,
vars,
);
_queryManager.trackedQueries[queryId] = newRef;
return newRef;
}
}

Expand Down
33 changes: 33 additions & 0 deletions ...ages/firebase_data_connect/firebase_data_connect/test/src/firebase_data_connect_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,5 +254,38 @@ void main() {
expect(routingTransport.websocket.auth, equals(mockAuth));
expect(routingTransport.websocket.appCheck, equals(mockAppCheck));
});

test('query returns identical QueryRef instance for identical queries', () {
final dynamicApp = DynamicMockFirebaseApp(
name: 'queryRefAppName',
options: const FirebaseOptions(
apiKey: 'fake_api_key',
appId: 'fake_app_id',
messagingSenderId: 'fake_messaging_sender_id',
projectId: 'fake_project_id',
),
);

final instance = FirebaseDataConnect(
app: dynamicApp,
connectorConfig: mockConnectorConfig,
);

final ref1 = instance.query(
'listMovies',
(json) => json,
emptySerializer,
null,
);

final ref2 = instance.query(
'listMovies',
(json) => json,
emptySerializer,
null,
);

expect(identical(ref1, ref2), isTrue);
});
});
}
Loading