Repository navigation
app: v3 Preview Debug Status shows the session's counters (row C25) - #1627
Merged
Merged
Conversation
Under v3 the View > Show Preview Debug Status toggle showed only the session's environment note. The v2 pane's debug strip showed its frame's id, revision and pages; the v3 pane now shows EngineV3Session.debugLine: host pid and host starts, the last DONE id (cancelled DONEs do not count), the layout revision, pages and stale pages, DONEs received, the keystroke-to-screen median (the status bar's, last 200 samples) and the environment note. Only fields the session already keeps. EngineV3DebugStatusTests feeds STARTED/PAGES/DONE to a session with FLASHTEX_HOST=none and a private FLASHTEX_V3_CACHE, and latency samples to a bare session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
Contributor
Author
|
CI run 37505201540: green. In the mac app job (112412041399), the full log (artifact mac-swift-test-log) shows that |
Contributor
Author
|
Independent review (kabir-claude reviewer, P5-APP-PARITY-FINISH): approve. Reviewed at c194967. I only read code and CI.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-lane of P5-APP-PARITY-FINISH, app-parity row C25 (Preview Debug Status, developer-facing).
Under v3, View > Show Preview Debug Status showed only
session.environmentNote(and only when ready). The v2 pane's strip (PreviewV2View.swift~:1052) showed the frame's id, project, revision, pages, window and fonts.EngineV3Session.debugLine(pure, computed): host pid or "no host", host starts, last DONE id (cancelled DONEs excluded, aslastDoneIDis), layout revision, pages and stale pages, DONEs received, keystroke-to-screen median over the last 200 samples (same computation as the status bar inShellChrome), environment note. Only fields the session already keeps; nothing new is tracked.PreviewV3StatusHUDshows it whenever the toggle is on (any phase), idengine-v3.debug-status.EngineV3DebugStatusTests:testTheDebugLineCarriesTheSessionsCounters(FLASHTEX_HOST=none, private FLASHTEX_V3_CACHE, no bundle; feeds STARTED/PAGES/DONE and a cancelled DONE) andtestTheDebugLineShowsTheKeystrokeMedian(latency samples on a bare session). Neither needs a host, so both run on hosted mac-app.Not done here: the v2 strip's font manifest has no v3 equivalent in the session; it is not invented.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp