chore(bash-lint): remove SC2034 disable directives by using _i loop variable - #1739
Merged
jamesadevine merged 1 commit intoJul 31, 2026
Conversation
…ariable Replace 'for i in $(seq ...)' with 'for _i in $(seq ...)' in the two MCPG wait-N-times loops in agentic_pipeline.rs. The loop variable was already intentionally unused; using a conventional _-prefixed name is the idiomatic shell fix and lets the inline disable comments be dropped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the lint found
Two
# shellcheck disable=SC2034directives remain insrc/compile/agentic_pipeline.rsfor MCPG wait-N-times loops (previously at lines 2878 and 2896):How it was fixed
Rule: SC2034 — variable assigned but unused.
Fix: Replace
for i inwithfor _i in. In POSIX-compatible shells, a variable name beginning with_is the conventional signal that the value is intentionally unused. shellcheck honours this convention and suppresses SC2034 for_-prefixed names, so the inline disable comments can be dropped entirely.Files touched:
src/compile/agentic_pipeline.rs(2 lines changed, 4 lines removed).Verification
No remaining
shellcheck disable=SC2034directives in the source tree.Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
releaseassets.githubusercontent.comspsprodeus21.vssps.visualstudio.comSee Network Configuration for more information.