Skip to content

chore(bash-lint): remove SC2034 disable directives by using _i loop variable #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 1 commit into from
Jul 31, 2026
Merged

chore(bash-lint): remove SC2034 disable directives by using _i loop variable #1739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/compile/agentic_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2875,8 +2875,7 @@ fn start_mcpg_step(
\n\
# Wait for MCPG to be ready\n\
READY=false\n\
# shellcheck disable=SC2034 # i is intentionally unused; wait-N-times loop\n\
for i in $(seq 1 30); do\n \
for _i in $(seq 1 30); do\n \
if curl -sf \"http://localhost:{MCPG_PORT}/health\" > /dev/null 2>&1; then\n \
echo \"MCPG is ready\"\n \
READY=true\n \
Expand All @@ -2893,8 +2892,7 @@ fn start_mcpg_step(
# Health check passing doesn't guarantee stdout is flushed, so poll.\n\
echo \"Waiting for gateway output file...\"\n\
GATEWAY_READY=false\n\
# shellcheck disable=SC2034 # i is intentionally unused; wait-N-times loop\n\
for i in $(seq 1 15); do\n \
for _i in $(seq 1 15); do\n \
if [ -s \"$GATEWAY_OUTPUT\" ] && jq -e '.mcpServers' \"$GATEWAY_OUTPUT\" > /dev/null 2>&1; then\n \
echo \"Gateway output is ready\"\n \
GATEWAY_READY=true\n \
Expand Down