feat(model): proved source semantics for nonreentrant(lock) (lane 2.2 step 1) - #2261
Merged
Conversation
…uard (lane 2.2) guarded slot body: executable semantics of the compiled tload/revert/ tstore prologue with success-path release. Laws: locked entry reverts with untouched state; free entry runs the body with the lock observably set and releases on success; reverting exits roll back the acquire; same-lock reentry is the identity as a state transformer, and whole reentry schedules collapse to the identity on locked states (runSeq_guarded_locked_id) — the reentry window is closed at the model level. TRUST_ASSUMPTIONS.md records what stays trusted: guarded ↔ attachNonReentrantGuard Yul correspondence and the noNonReentrant fragment restriction.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_eacee24a-539b-4f1f-b866-e04f2b41d0f5) |
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of lane 2.2:
Verity.Core.Model.NonReentrantGuard.guarded— executable source semantics of the compiled transient-lock prologue (attachNonReentrantGuard), with the guard laws proved:guarded_locked_reverts/guarded_reentry_blocked: lock held ⇒ revert, state untouched; identity as a state transformer.guarded_free_runs_body+body_observes_lock+guarded_success_releases: lock free ⇒ body runs under an observably set lock, successful exits release it (same-tx sequential calls stay allowed), reverting exits roll back the acquire.runSeq_guarded_locked_id: whole reentry schedules of same-lock guarded entrypoints collapse to the identity on locked states — closes the reentry window at schedule level, composing withCallbackBounded(feat(model): callback-bounded adversaries — reentrancy specs at the call boundary (#1963 slice 6) #2260).Still open (documented in TRUST_ASSUMPTIONS.md):
guarded↔ emitted-Yul correspondence, and lifting the supported-fragmentnoNonReentrantrestriction.Validation: full
lake buildOK,make checkall passed, no sorry/admit/new axiom.Note
Medium Risk
Touches the security-critical reentrancy model, but is additive Lean proof infrastructure with no compiler or runtime emission changes. Correspondence to emitted Yul remains an open trust boundary.
Overview
Adds proved source-level semantics for the compiled
nonreentrant(lock)transient-storage guard via newVerity.Core.Model.NonReentrantGuard.guarded.When the lock is free, the body runs under an observably set lock and successful exits release it (reverts roll back the acquire). When held, same-lock guarded entrypoints revert with state unchanged — so whole reentry schedules collapse to the identity (
runSeq_guarded_locked_id), closing the reentry window at the model level and composing withCallbackBounded/ReentrancySpec.Updates
TRUST_ASSUMPTIONS.mdaccordingly. Still trusted: correspondence ofguardedto Yul fromattachNonReentrantGuard, and the supported-fragmentnoNonReentrantrestriction.Reviewed by Cursor Bugbot for commit 29211e8. Bugbot is set up for automated code reviews on this repo. Configure here.