proof(ir): nonreentrant guard prologue semantics (lane 2.2 step 2) - #2262
Merged
Conversation
…eter (lane 2.2 step 2) Prove the exact statements emitted by nonReentrantGuardPrologue and the spliced lock release under execIRStmts/execIRStmt: - locked entry (tload = 1) reverts with the state untouched; - free entry acquires the lock and changes nothing else; - the release resets the slot; acquire+release round-trips the transient store extensionally; - the Yul decision eq(lock,1) agrees with the source model's lock != 0 on reachable binary lock values (guard_decision_agrees); - nonReentrantGuardPrologue_eq pins the emitted shape. TRUST_ASSUMPTIONS.md updated; PrintAxioms regenerated.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_fbf9575e-c22e-4104-b145-2ff2753b8440) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine-checks the compiled side of the guard begun in #2261: the exact prologue
if eq(tload(slot),1) { revert } ; tstore(slot,1)and the spliced releasetstore(slot,0)are evaluated under the IR-generation interpreter (execIRStmts/execIRStmt), proving locked-entry revert (state untouched), free-entry acquire (nothing else changed), release reset with extensional acquire/release round-trip, decision agreement withNonReentrantGuard.guardedon reachable binary lock values, and the emitted-shape pinnonReentrantGuardPrologue_eq.Remaining for the full
noNonReentrantlift (documented in TRUST_ASSUMPTIONS.md): threading throughattachNonReentrantGuard/compileGuardedFunctionSpecandcompile_preserves_semantics— blocked mainly byspliceLockRelease/yulFrameHaltsbeingpartial def.Validation: full
lake build(2468 jobs) OK,make checkall passed, PrintAxioms regenerated, no sorry/admit/new axiom.Note
Low Risk
Additive Lean proofs and trust-doc updates only; no compiler or runtime behavior changes, and no new axioms or sorry.
Overview
Adds the first machine-checked IR-side brick for the
nonreentrantguard: the exact prologue/release Yul statements are now evaluated underexecIRStmts/execIRStmt.NonReentrantGuardIRpins the emitted prologue shape and proves locked entry reverts with state untouched, free entry acquires the lock only, the spliced release resets it (acquire/release round-trips transient storage), and Yuleq(lock,1)agrees with the source model'slock ≠ 0on binary lock values.Updates
TRUST_ASSUMPTIONS.mdaccordingly: statement-level IR facts are proved; threading throughattachNonReentrantGuard/compile_preserves_semanticsand liftingnoNonReentrantremain trusted. Registers the six new theorems inPrintAxioms(+6 public, 0 sorry).Reviewed by Cursor Bugbot for commit 3439b07. Bugbot is set up for automated code reviews on this repo. Configure here.