proof(ir): attachNonReentrantGuard output shape (lane 2.2) - #2275
Merged
Conversation
attachNonReentrantGuard_some_shape: for an annotated function with a resolved lock field, the transformation's output is exactly param-loads ++ guardPrologueStmts slot ++ applyLockReleaseOnExits over the body suffix — pinning the object the composed guard laws (#2272- #2274) talk about to the transformation's actual output.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_8cfd2071-eab9-4724-9d44-47e39535726c) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This was referenced Aug 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the guarded compilation unit to its proved pieces:
attachNonReentrantGuard_some_shapeshows the transformation's output is exactlytake paramLoads ++ guardPrologueStmts slot ++ applyLockReleaseOnExits (release slot) (drop paramLoads)— the precise object of #2262/#2272/#2273/#2274. What remains for the full lift is the param-load prefix semantics + nested-control-flow splice points + threading into compile_preserves_semantics.Validation: full
lake buildOK,make checkall passed, no sorry/admit/new axiom.Note
Low Risk
Proof-only addition with no compiler or runtime behavior change; registers one new theorem and bumps the axiom inventory count.
Overview
Adds
attachNonReentrantGuard_some_shape, proving that when a lock is present the transformation yields exactly param-loads ++guardPrologueStmts++applyLockReleaseOnExitson the remaining body.This ties the already-proved composed guard laws to the compiler's actual output shape, advancing the lane-2.2 nonreentrant IR correspondence. Also registers the theorem in
PrintAxioms.lean.Reviewed by Cursor Bugbot for commit b6e4900. Bugbot is set up for automated code reviews on this repo. Configure here.