proof(ir): applyLockReleaseOnExits halting branch — wrapper fully characterized (lane 2.2) - #2293
Merged
Merged
Conversation
ModeledHalt (the frame halts the interpreter actually halts: stop(), return(lit,lit), revert(a,b)) with no-continue soundness at any fuel and through whole bodies (execIRStmts_last_halt_no_continue), plus execIRStmts_applyLockReleaseOnExits_halting: a fragment body ending in a modeled halt gets no trailing release and the wrapped execution equals the original with halts carrying the released state. Both wrapper branches are now characterized; the invalid/selfdestruct analysis gap is documented in the ModeledHalt docstring.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e3e83815-b06d-4019-94ea-789d9c96bd3e) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the wrapper:
ModeledHalt+ no-continue soundness (execIRStmt_modeledHalt_no_continue,execIRStmts_last_halt_no_continue) andexecIRStmts_applyLockReleaseOnExits_halting— with #2292's fall-through branch,applyLockReleaseOnExitsis now fully characterized over the fragment: every outcome of the wrapped body equals the original with successful exits carrying the released state. Theinvalid/selfdestructanalysis-vs-interpreter gap is scoped out explicitly inModeledHalt. Next: compose with the prologue laws (#2274/#2275) into the guarded-unit end-to-end statement.Validation: full
lake buildOK,make checkall passed, no sorry/admit/new axiom.Note
Low Risk
Proof-only additions in Lean with no runtime or compiler behavior changes; risk is limited to proof maintenance and axiom inventory accuracy.
Overview
Adds the halting-analysis branch of
applyLockReleaseOnExitsto the IR splice simulation proofs, pairing with the existing fall-through theorem so the wrapper is characterized on the supported fragment.Introduces
ModeledHaltfor interpreter-real halts (stop, literalreturn,revert) and deliberately omitsinvalid/selfdestruct, where static halt analysis and execution disagree. New lemmas show modeled halts never yield.continue(single stmt andys ++ [h]), and thatModeledHalt.frameHaltsaligns them withyulFrameHalts.execIRStmts_applyLockReleaseOnExits_haltingproves that when aSpliceSimListbody ends in a modeled halt, the wrapper takes the splice-only path (no trailing release) and wrapped execution matches the original with successful exits carryingreleaseState, ruling out the impossible.continuecase.PrintAxioms.leanregisters the four new public theorems (6237 total).Reviewed by Cursor Bugbot for commit af350cb. Bugbot is set up for automated code reviews on this repo. Configure here.