proof(ir): end-to-end guarded unit (lane 2.2 milestone) - #2294
Merged
Conversation
…r the fragment (lane 2.2) execIRStmts_guardedUnit_fallthrough/_halting compose the prologue laws (#2274) with both wrapper branches (#2292/#2293): the compiled prologue + release-wrapped body mirrors NonReentrantGuard.guarded exactly over the SpliceSim fragment — locked entry reverts untouched; free entry runs the body from the acquired state with every successful outcome carrying the released state. TRUST_ASSUMPTIONS.md updated: the remaining trusted steps are switch/loop bodies, the invalid/selfdestruct halt-analysis gap, and the compile_preserves_semantics threading.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ee37d648-d4d1-45ce-bbe5-3cd219495f49) |
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lane's IR-side capstone:
execIRStmts_guardedUnit_fallthrough/_haltingcompose the prologue laws (#2274/#2275) with both wrapper branches (#2292/#2293), proving the compiled guarded unit mirrorsVerity.Core.Model.NonReentrantGuard.guardedexactly over theSpliceSimfragment: locked entry ⇒ revert untouched; free entry ⇒ body runs from the acquired state, successful outcomes released, reverts roll back the acquire.TRUST_ASSUMPTIONS.md updated — remaining trusted:
switch/loop guarded bodies, theinvalid/selfdestructhalt-analysis gap, and thecompile_preserves_semanticsthreading for thenoNonReentrantlift.Validation: full
lake buildOK,make checkall passed, no sorry/admit/new axiom.Note
Low Risk
Proof-only additions and documentation; no runtime compiler or auth changes.
Overview
Adds
execIRStmts_guardedUnit_fallthroughandexecIRStmts_guardedUnit_haltinginSpliceSimulation.lean, showing thatguardPrologueStmtsplusapplyLockReleaseOnExitson the IR interpreter matchesNonReentrantGuard.guarded: lock held ⇒ revert with unchanged state; lock free ⇒ body runs after acquire and successful exits release the lock.Each proof is a short case split on lock 0/1, wiring
guardedBody_locked_reverts/guardedBody_free_runs_suffixto the existingapplyLockReleaseOnExitsfall-through and modeled-halt lemmas.PrintAxioms.leanregisters the two new theorems (6237 → 6239 total).TRUST_ASSUMPTIONS.mdrecords that the loop/switch-free guarded unit is now proved end-to-end and narrows what remains trusted (switch/loops,ModeledHaltgap,compile_preserves_semantics/noNonReentrantlift).Reviewed by Cursor Bugbot for commit 0e38d1d. Bugbot is set up for automated code reviews on this repo. Configure here.