proof(ir): attachNonReentrantGuard correctness (lane 2.2 semantic closure) - #2297
Merged
Conversation
attachNonReentrantGuard_exec: for an annotated function whose compiled body has the standard loads-then-body shape, the transformed function's body executes exactly as the guarded composition — locked entry reverts after binding, free entry runs the body from the acquired bound state with successful outcomes released. Composes the shape pin (#2275) with the full function composition (#2296); the semantic content of the noNonReentrant lift is now complete, leaving only the whole-contract integration plumbing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6feade1a-7e0f-4e86-a77e-e00c02890c99) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transformation-level correctness statement:
attachNonReentrantGuard_execcomposes the output-shape pin (#2275) with the full guarded-function composition (#2296) — for any annotated function with the standardgenParamLoads ++ bodycompiled shape, the transformed body provably executes asguarded: bind, check, acquire, run, release. This closes the semantic content of thenoNonReentrantlift; what remains is integration plumbing (consuming this from the whole-contract preservation theorems), which is additive engineering with no new proof obstacles.Validation: full
lake buildOK,make checkall passed, no sorry/admit/new axiom.Note
Low Risk
Proof-only change in Lean formal verification; no runtime compiler or contract behavior is modified.
Overview
Adds
attachNonReentrantGuard_exec, a formal correctness theorem for the post-compilation non-reentrant guard transform: whenattachNonReentrantGuardsucceeds on a function whose IR body isgenParamLoads ++ bodyStmts, executing the guarded body matches the intended guarded semantics (bind params, revert if lock held, else acquire lock, run body, release on success).The proof is a thin composition:
attachNonReentrantGuard_some_shapepins the transformed body shape, thenexecIRStmts_guardedFunction_fallthroughsupplies the execution equivalence. The theorem is registered inPrintAxioms.lean(theorem count 6249 → 6250).Reviewed by Cursor Bugbot for commit 641ad7e. Bugbot is set up for automated code reviews on this repo. Configure here.