fix: send empty login password as zero bytes for read-only ACL#29
Open
rinchen wants to merge 1 commit into
Open
fix: send empty login password as zero bytes for read-only ACL#29rinchen wants to merge 1 commit into
rinchen wants to merge 1 commit into
Conversation
Room/repeater guest (read-only) login uses a zero-length password payload, matching the official MeshCore Android companion. Explicitly skip writeString when password is empty so the frame ends after the public key. Carried as a pnpm patch in Colorado-Mesh/mesh-client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeStringas before.Context
Colorado-Mesh/mesh-client currently carries this as a pnpm patch against
@liamcottle/meshcore.js@1.13.0. Upstreaming so other clients get correct read-only room/repeater login without a local patch.Test plan
LoginSuccess