Skip to content

fix: send empty login password as zero bytes for read-only ACL #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rinchen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: send empty login password as zero bytes for read-only ACL #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/connection/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,10 @@ class Connection extends EventEmitter {
const data = new BufferWriter();
data.writeByte(Constants.CommandCodes.SendLogin);
data.writeBytes(publicKey); // 32 bytes - id of repeater or room server
data.writeString(password); // password is remainder of frame, max 15 characters
// Empty password = read-only ACL (0 bytes, matches official Android). Non-empty uses writeString.
if (password.length > 0) {
data.writeString(password); // password is remainder of frame, max 15 characters
}
await this.sendToRadioFrame(data.toBytes());
}

Expand Down