Skip to content

vmm_tests: Fix serial interrupt test race - #4186

Merged
Steven Malis (smalis-msft) merged 2 commits into
microsoft:mainfrom
smalis-msft:fix-serial-test
Aug 7, 2026
Merged

vmm_tests: Fix serial interrupt test race#4186
Steven Malis (smalis-msft) merged 2 commits into
microsoft:mainfrom
smalis-msft:fix-serial-test

Conversation

@smalis-msft

Copy link
Copy Markdown
Contributor

Write a larger amount of data to the serial device to ensure that it triggers interrupts as needed.

Copilot AI lite review requested due to automatic review settings August 7, 2026 17:09
@smalis-msft
Steven Malis (smalis-msft) requested a review from a team as a code owner August 7, 2026 17:09
@smalis-msft Steven Malis (smalis-msft) added the backport_1.8.2607 Change should be backported to the release/1.8.2607 branch label Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PCIe multiarch VMM test that verifies IOAPIC interrupt remapping by generating larger serial output, reducing a race where the “after” /proc/interrupts snapshot could be taken before the serial transmission triggered interrupts.

Changes:

  • Replace a small repeated echo loop with a larger dd write to overflow the tty transmit buffer and force interrupt-driven draining.
  • Add test-local documentation explaining why a larger write is required.
  • Introduce a TX_PAGES constant to parameterize the amount of serial traffic generated.

Comment thread vmm_tests/vmm_tests/tests/tests/multiarch/pcie.rs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 7, 2026 17:13
@smalis-msft
Steven Malis (smalis-msft) enabled auto-merge (squash) August 7, 2026 17:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

@smalis-msft
Steven Malis (smalis-msft) merged commit 43e4012 into microsoft:main Aug 7, 2026
68 of 69 checks passed
@smalis-msft
Steven Malis (smalis-msft) deleted the fix-serial-test branch August 7, 2026 19:56
Matt LaFayette (Kurjanowicz) (mattkur) added a commit that referenced this pull request Aug 8, 2026
Clean cherry pick of PR #4186

Write a larger amount of data to the serial device to ensure that it
triggers interrupts as needed.

Co-authored-by: Steven Malis <137308034+smalis-msft@users.noreply.github.com>
@benhillis

Copy link
Copy Markdown
Member

Backported to release/1.8.2607 in #4194

@benhillis Ben Hillis (benhillis) added backported_1.8.2607 PR that has been backported to release/1.8.2607 and removed backport_1.8.2607 Change should be backported to the release/1.8.2607 branch labels Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported_1.8.2607 PR that has been backported to release/1.8.2607

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants