vmm_tests: Fix serial interrupt test race (#4186) - #4194
Merged
Matt LaFayette (Kurjanowicz) (mattkur) merged 1 commit intoAug 8, 2026
Conversation
Write a larger amount of data to the serial device to ensure that it triggers interrupts as needed. (cherry picked from commit 43e4012)
Matt LaFayette (Kurjanowicz) (mattkur)
requested a review
from a team
as a code owner
August 7, 2026 21:55
github-actions
Bot
added
the
release_1.8.2607
Copilot started reviewing on behalf of
Matt LaFayette (Kurjanowicz) (mattkur)
August 7, 2026 21:55
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the vmm_tests PCIe multiarch test to make the IOAPIC interrupt-remapping verification more reliable by generating enough serial traffic to deterministically drive IRQ delivery (avoiding a race where the second /proc/interrupts snapshot could occur before interrupts fire).
Changes:
- Replace many small
echowrites with a single largerddwrite to/dev/ttyS1to better guarantee interrupt activity. - Expand and clarify the in-test rationale around
set -eand why the write size must exceed the tty transmit buffer.
Ben Hillis (benhillis)
approved these changes
Aug 7, 2026
Matt LaFayette (Kurjanowicz) (mattkur)
merged commit Aug 8, 2026
b8e4e4f
into
microsoft:release/1.8.2607
65 checks passed
Matt LaFayette (Kurjanowicz) (mattkur)
deleted the
cherrypick/release/1.8.2607/pr-4186
branch
August 8, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean cherry pick of PR #4186
Write a larger amount of data to the serial device to ensure that it triggers interrupts as needed.