[9/n] [sync-switch] bail on an incomplete bootstore config instead of silently dropping items#10650
Conversation
Created using spr 1.3.6-beta.1
This was referenced Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, on encountering a transient DB issue, we would silently drop items from the bootstore config. That seems quite obviously bad and was part of the reason #10640 escalated a crdb bug into persistent bootstore corruption.
Rework all this by:
This is a functional change that is worth thinking very hard about. Many but not all of the invariants here are maintained by the database layer. If there's persistent db corruption or a similar issue, we will no longer generate a bootstore config for the rack! I think this is overall the right thing to do, but it is quite possible there are latent issues that were being hidden by the looser error handling that this code previously had.
The report is now logged by the background task, unless the task exits with one of the other early errors. (There's a much larger rework of the task that needs to be done, but I'm not doing that here since it'll collide with a lot of what @jgallagher is currently doing.)
Depends on: