validate options passed to socket longpoll / websocket options#6072
Merged
Conversation
josevalim
approved these changes
Feb 5, 2025
josevalim
left a comment
josevalim
left a comment
Member
There was a problem hiding this comment.
LGTM but let's not backport this one, as it may crash!
|
Just wondering whether it was intentional to include only a subset of the websock_adapter opts in the list of keys? In particular we're relying on |
giddie
added a commit
to Whatnot-Inc/phoenix
that referenced
this pull request
May 13, 2026
Validation was added in this PR: phoenixframework#6072
Contributor
|
#6758 Opened this one to add missing config keys that websock_adapter supports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot validate options other than websocket / longpoll, because they might be used by custom sockets. See ab2ff9e#diff-5ab73ffaee87d2c9de2a1455f11157d5d3c0dd01157ee019d58d37b19dafd68eR29.
@josevalim please double check if validating the websocket / longpoll keys is actually fine.