Conversation
ceache
requested review from
StephenSorriaux,
a-ungurianu,
bbangert and
jeffwidman
September 14, 2026 02:51
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 27 27
Lines 3811 3811
=======================================
Hits 3619 3619
Misses 192 192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ceache
force-pushed
the
feature/ruff-migration
branch
from
September 14, 2026 04:39
16b296f to
17edcda
Compare
ThosRTanner
reviewed
Sep 14, 2026
Contributor
|
FIxes #774 I think |
ceache
force-pushed
the
feature/ruff-migration
branch
2 times, most recently
from
September 18, 2026 01:29
cbb7f79 to
eaf133f
Compare
ceache
force-pushed
the
feature/ruff-migration
branch
from
September 18, 2026 02:05
eaf133f to
64cf8a7
Compare
ceache
force-pushed
the
feature/ruff-migration
branch
from
September 19, 2026 01:23
64cf8a7 to
4f2d638
Compare
ceache
force-pushed
the
feature/ruff-migration
branch
from
September 19, 2026 01:30
4f2d638 to
8917f5d
Compare
ceache
force-pushed
the
feature/ruff-migration
branch
from
September 19, 2026 01:35
8917f5d to
8759aee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #774
Summary
This PR modernizes Kazoo's linting, formatting, and PR review workflow:
blackandpep8tox virtualenvs in CI with a single unifiedruffenvironment, significantly speeding up validation runs.Important: Branch Protection Update Required
In
python-zk/kazoorepository settings, themasterbranch protection rule currently hasHoundlisted underrequired_status_checks:Houndfrom the required status checks in branch protection settings (and optionally requireCode Validationinstead).Key Changes
.hound.ymland.flake8.reviewdog/action-setup@v1to.github/workflows/testing.ymlusing Ruff's native--output-format=rdjsonwith-reporter=github-pr-reviewand-filter-mode=added. This replicates HoundCI's inline commenting on PR diffs without external third-party bot flakiness.[tool.black]with[tool.ruff],[tool.ruff.lint], and[tool.ruff.format]inpyproject.toml.select = ["E", "F", "W"],builtins = ["_"], matching ignoresE203, E721, F401, F811, F821) andline-length = 79to maintain consistency with existing Flake8 and Black rules.target-version = "py39".ruff==0.16.7in[dependency-groups]and dropped unusedblackandpep8groups.[testenv:ruff]intox.inirunning bothruff checkandruff format --check.[testenv:pep8]and[testenv:black]for local developer workflows with deprecation notices pointing developers to theruffenvironment..github/workflows/testing.ymlto runTOX_VENV: ruff,mypy(one lint/format virtualenv instead of two)..git-blame-ignore-revsunder# Reformat using ruff 0.16.7to preserve git blame history.Verification
tox -e ruff,mypy: All checks pass cleanly (62 files formatted, 0 lint violations, 0 typing issues).tox -e pep8andtox -e black: Display deprecation notices and pass.