Skip to content

Fixes to base.plot_box() - #179

Open
petercorke wants to merge 1 commit into
rai-opensource:masterfrom
petercorke:fix/base-plot-box
Open

Fixes to base.plot_box()#179
petercorke wants to merge 1 commit into
rai-opensource:masterfrom
petercorke:fix/base-plot-box

Conversation

@petercorke

Copy link
Copy Markdown
Collaborator

Improve handling of the "format string" arg.
Provide a US-spelling version of the 'centre' option, either 'center' or 'centre' will work.
Prevent multiple Matplotlib arguments of the same name being passed to plt.Rectangle, as happens from plot_labelbox. Improve the docstring.

Minor fix in docstring for plot_arrow, tex string should be raw. This upsets Sphinx when any other package imports spatialmath.

Provide a US-spelling version of the 'centre' option, either 'center' or 'centre' will work.
Prevent multiple Matplotlib arguments of the same name being passed to `plt.Rectangle`, as happens from `plot_labelbox`.
Improve function docstring.
Minor fix in docstring for `plot_arrow`, tex string should be raw.  This upsets Sphinx when any other package imports spatialmath.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
spatialmath/base/graphics.py 58.33% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

petercorke added a commit to petercorke/spatialmath-python that referenced this pull request Jul 27, 2026
Comprehensive handover tracking:
- Original problem statement (PR rai-opensource#179 stuck)
- Full plan with 4 phases
- Action to date (3 PRs pushed/ready)
- Action going forward (next 3 branches + guidelines)
- Status table and next-session checklist

This document serves as the source of truth for PR work state
and continuation instructions for future sessions.
@petercorke

Copy link
Copy Markdown
Collaborator Author

Merge-order suggestion across the currently open PRs, based on a full file-overlap check across all of them. Nothing here is a conflict with anything already merged — these are parallel PRs sharing some source files with each other, so a rebase will likely be needed wherever paths cross, regardless of order.

Recommended order:

  1. Fixes to base.plot_box() #179 (fix/base-plot-box) — already approved, CI green, ready now (this one)
  2. Fix/twist pitch clean #196 (fix/twist-pitch-clean) — isolated to twist.py
  3. test: force headless Matplotlib backend for local + CI test runs #197 (fix/headless-tests-locally) — isolated to test files only
  4. docs: fix Sphinx docstring formatting and reST syntax errors #195 (docs/sphinx-docstring-fixes) — touches ~18 files, overlaps most of the PRs below; docstring-only/low-risk, so merging it here means the functional PRs below each only rebase against it once
  5. feat(pose,quaternion): add __imatmul__ (@=) operator #199 (feat/imatmul) — only conflicts with refactor: consistent printline() across pose and quaternion classes #200
  6. fix(base): export tr2pos2, pos2tr2, tr2adjoint2; rename tradjoint2 #194 (fix/export-base-functions) — conflicts with perf: defer Matplotlib import until something actually plots #198 and refactor: consistent printline() across pose and quaternion classes #200
  7. perf: defer Matplotlib import until something actually plots #198 (perf/lazy-matplotlib-import) — conflicts with fix(base): export tr2pos2, pos2tr2, tr2adjoint2; rename tradjoint2 #194 and refactor: consistent printline() across pose and quaternion classes #200
  8. refactor: consistent printline() across pose and quaternion classes #200 (refactor/printline) — touches the most shared surface (conflicts with fix(base): export tr2pos2, pos2tr2, tr2adjoint2; rename tradjoint2 #194, perf: defer Matplotlib import until something actually plots #198, feat(pose,quaternion): add __imatmul__ (@=) operator #199); merging it last means it absorbs one final rebase instead of three others rebasing against it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants