Skip to content

fix(frontend): build ladle correctly#5027

Open
jog1t wants to merge 1 commit into
05-06-feat_frontend_improve_runners_errors_uifrom
05-06-fix_frontend_build_ladle_correctly
Open

fix(frontend): build ladle correctly#5027
jog1t wants to merge 1 commit into
05-06-feat_frontend_improve_runners_errors_uifrom
05-06-fix_frontend_build_ladle_correctly

Conversation

@jog1t
Copy link
Copy Markdown
Contributor

@jog1t jog1t commented May 11, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 11, 2026

PR Review

What the PR does: Adds missing COPY of rivetkit-wasm package to all three frontend Dockerfiles (cloud, inspector, ladle) and sets SKIP_WASM_BUILD=1 to avoid invoking wasm-pack (which needs a Rust toolchain not present in these images).

Assessment: Fix is correct and minimal. SKIP_WASM_BUILD is properly consumed in rivetkit-wasm/scripts/build.mjs — it checks for '1' or 'true' and exits early. Since no pre-built pkg/ artifacts are committed, the build logs 'skipped', which is fine because Vite/esbuild does not run tsc type-checking; the package just needs to be present for pnpm install to succeed. The change is applied consistently across all three Dockerfiles, SKIP_WASM_BUILD=1 is correctly placed before pnpm install, and the variable is already in turbo.json passthrough env so cache keys include it.

No blocking issues.

Minor notes:

  • PR title says 'build ladle correctly' but all three Dockerfiles are changed. A more accurate title: fix(frontend): add rivetkit-wasm to docker build contexts.
  • Dockerfile comment style: uses a semicolon to join two sentences. Per CLAUDE.md, separate sentences with a period.
  • SKIP_NAPI_BUILD is not needed here because rivetkit-napi is not COPY'd into these images. This is correct.

Conclusion: Good, targeted fix. Safe and consistent across all three images.

@jog1t jog1t force-pushed the 05-06-feat_frontend_improve_runners_errors_ui branch from 998ae2d to 3e2bff1 Compare May 11, 2026 18:49
@jog1t jog1t force-pushed the 05-06-fix_frontend_build_ladle_correctly branch from d1dc356 to 331cbe7 Compare May 11, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant