Skip to content

chore: regenerate sdk#5036

Merged
jog1t merged 1 commit into
mainfrom
05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list
May 15, 2026
Merged

chore: regenerate sdk#5036
jog1t merged 1 commit into
mainfrom
05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list

Conversation

@jog1t
Copy link
Copy Markdown
Contributor

@jog1t jog1t commented May 11, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 11, 2026

PR Review: chore: regenerate sdk

Overview: Small frontend-only change (+8/-2) across three files: new serverless provider labels, a fallback for a missing publishable token, and a virtualizer remeasurement fix.


Change 1 — getting-started.tsx: Publishable token fallback

publishableToken: publishableRawToken ?? "<PUBLISHABLE_TOKEN>",

Good: Prevents undefined from being passed downstream when the token has not loaded yet.

Concern: The literal string "<PUBLISHABLE_TOKEN>" will appear verbatim in code snippets shown to the user. If the token is still loading (rather than genuinely absent), users could copy a broken snippet. Consider a loading guard or skeleton state for clearer UX.


Change 2 — serverless-connection-check.tsx: New provider labels

.with("cloudflare-workers", () => "Cloudflare Workers")
.with("supabase-functions", () => "Supabase Functions")

Good: Explicitly enumerates new discriminated-union variants rather than a catch-all, consistent with the project match-statement convention.

Question: Is the match(...) chain terminated with .exhaustive()? If so the compiler would have flagged these already. If using .otherwise(...), check whether any other new SDK provider variants are still silently falling through.


Change 3 — actors-list.tsx: Virtualizer remeasurement

useEffect(() => {
    rowVirtualizer.measure();
}, [rowVirtualizer]);

Potential issue: @tanstack/react-virtual's useVirtualizer may return a new object reference on every render. If rowVirtualizer is not referentially stable, this effect fires on every render and calls measure() unnecessarily, which can cause layout thrashing on a long list. Verify stability before merging, or use [] as the dependency if the intent is a one-time post-mount measurement.


General

  • PR description is empty — no context on what was regenerated or how these UI fixes relate.
  • No tests needed for label changes, but the virtualizer fix warrants a quick manual smoke test with a large actors list.

Net assessment: Low risk. The provider labels and token fallback are straightforward. The virtualizer useEffect warrants a stability check before landing.

@jog1t jog1t marked this pull request as ready for review May 11, 2026 18:42
@jog1t jog1t force-pushed the 05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list branch from cf92344 to a3e0d8a Compare May 11, 2026 18:49
@jog1t jog1t force-pushed the 05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list branch from a3e0d8a to 69efc1f Compare May 15, 2026 19:30
@jog1t jog1t force-pushed the 05-11-feat_frontend_allow_creating_serverfull_instances_during_onboarding branch from 81994b8 to 4b2680f Compare May 15, 2026 19:30
@jog1t jog1t mentioned this pull request May 15, 2026
11 tasks
Copy link
Copy Markdown
Contributor Author

jog1t commented May 15, 2026

Merge activity

  • May 15, 7:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 15, 8:05 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 15, 8:05 PM UTC: @jog1t merged this pull request with Graphite.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 15, 2026

Code Review

Overview: This PR makes three small frontend UI changes necessitated by the addition of cloudflare-workers and supabase-functions to the Provider union in @rivetkit/shared-data: (1) serverless-connection-check.tsx adds display names for the two new providers to satisfy a .exhaustive() TypeScript check, (2) getting-started.tsx adds a null-safety fallback for publishableRawToken, (3) actors-list.tsx forces virtualizer remeasurement on mount.

Issues - PR metadata: The title 'chore: regenerate sdk' does not describe what this PR actually does. Something like 'fix: add cloudflare-workers and supabase-functions provider UI support' would be more accurate. The PR description template is also entirely unfilled.

serverless-connection-check.tsx: This change is correct and necessary. Adding the two .with() arms is the right fix per the project convention of enumerating all variants explicitly. Minor: the commented-out .with('rivet', ...) arm can be deleted if 'rivet' has been removed from the Provider type, or a note added if intentionally excluded.

getting-started.tsx: The ?? '<PUBLISHABLE_TOKEN>' fallback is reasonable. Fine as-is.

actors-list.tsx: useVirtualizer maintains a stable instance via useState, so the effect fires exactly once after mount. Correct semantics if the intent is to force an initial measurement. If the root cause is actors loading asynchronously and the container height being wrong after items appear, adding actors.length as a dependency would be more targeted. Not a blocker but worth verifying.

Potential gap in runner-config-table.tsx: PROVIDER_LABELS does not include cloudflare-workers or supabase-functions. The getProviderLabel function falls back to returning the raw key so there is no crash, but if these providers can surface in runner config rows they will show without a human-friendly label or icon. Worth confirming these providers are serverless-only and will never appear in that table, or adding entries there too.

Summary: The core change (exhaustive provider matching) is correct. Main asks before merge: (1) Update the PR title and fill out the description. (2) Clarify the useEffect dependency intent and whether actors.length should be included. (3) Confirm or fix the runner-config-table.tsx gap for the new providers.

@jog1t jog1t changed the base branch from 05-11-feat_frontend_allow_creating_serverfull_instances_during_onboarding to graphite-base/5036 May 15, 2026 20:01
@jog1t jog1t changed the base branch from graphite-base/5036 to main May 15, 2026 20:03
@jog1t jog1t force-pushed the 05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list branch from 69efc1f to b6205ad Compare May 15, 2026 20:04
@jog1t jog1t merged commit 3fe3dbd into main May 15, 2026
9 of 11 checks passed
@jog1t jog1t deleted the 05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list branch May 15, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant