chore: regenerate sdk#5036
Conversation
PR Review: chore: regenerate sdkOverview: Small frontend-only change (+8/-2) across three files: new serverless provider labels, a fallback for a missing publishable token, and a virtualizer remeasurement fix. Change 1 —
|
cf92344 to
a3e0d8a
Compare
a3e0d8a to
69efc1f
Compare
81994b8 to
4b2680f
Compare
|
Code Review Overview: This PR makes three small frontend UI changes necessitated by the addition of cloudflare-workers and supabase-functions to the Provider union in @rivetkit/shared-data: (1) serverless-connection-check.tsx adds display names for the two new providers to satisfy a .exhaustive() TypeScript check, (2) getting-started.tsx adds a null-safety fallback for publishableRawToken, (3) actors-list.tsx forces virtualizer remeasurement on mount. Issues - PR metadata: The title 'chore: regenerate sdk' does not describe what this PR actually does. Something like 'fix: add cloudflare-workers and supabase-functions provider UI support' would be more accurate. The PR description template is also entirely unfilled. serverless-connection-check.tsx: This change is correct and necessary. Adding the two .with() arms is the right fix per the project convention of enumerating all variants explicitly. Minor: the commented-out .with('rivet', ...) arm can be deleted if 'rivet' has been removed from the Provider type, or a note added if intentionally excluded. getting-started.tsx: The ?? '<PUBLISHABLE_TOKEN>' fallback is reasonable. Fine as-is. actors-list.tsx: useVirtualizer maintains a stable instance via useState, so the effect fires exactly once after mount. Correct semantics if the intent is to force an initial measurement. If the root cause is actors loading asynchronously and the container height being wrong after items appear, adding actors.length as a dependency would be more targeted. Not a blocker but worth verifying. Potential gap in runner-config-table.tsx: PROVIDER_LABELS does not include cloudflare-workers or supabase-functions. The getProviderLabel function falls back to returning the raw key so there is no crash, but if these providers can surface in runner config rows they will show without a human-friendly label or icon. Worth confirming these providers are serverless-only and will never appear in that table, or adding entries there too. Summary: The core change (exhaustive provider matching) is correct. Main asks before merge: (1) Update the PR title and fill out the description. (2) Clarify the useEffect dependency intent and whether actors.length should be included. (3) Confirm or fix the runner-config-table.tsx gap for the new providers. |
69efc1f to
b6205ad
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: