Skip to content

fix: wasm-pack build#5048

Merged
abcxff merged 1 commit into
mainfrom
05-12-temp_fix_wasm-pack
May 13, 2026
Merged

fix: wasm-pack build#5048
abcxff merged 1 commit into
mainfrom
05-12-temp_fix_wasm-pack

Conversation

@abcxff
Copy link
Copy Markdown
Contributor

@abcxff abcxff commented May 12, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link
Copy Markdown

railway-app Bot commented May 12, 2026

🚅 Deployed to the rivet-pr-5048 environment in rivet-frontend

Service Status Web Updated (UTC)
kitchen-sink ❌ Build Failed (View Logs) Web May 13, 2026 at 8:09 pm
website ❌ Build Failed (View Logs) Web May 13, 2026 at 6:51 pm
frontend-inspector ❌ Build Failed (View Logs) Web May 13, 2026 at 6:51 pm
frontend-cloud ❌ Build Failed (View Logs) Web May 13, 2026 at 6:50 pm
ladle ❌ Build Failed (View Logs) Web May 13, 2026 at 6:50 pm
mcp-hub ✅ Success (View Logs) Web May 12, 2026 at 2:54 pm

Copy link
Copy Markdown
Contributor Author

abcxff commented May 12, 2026

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 12, 2026

Code Review: fix: wasm-pack build

Overview

This PR fixes a broken wasm-pack build by patching wasm-pack@0.14.0 via pnpm patchedDependencies. The root cause is that binary.js hardcodes drager as the GitHub org for binary downloads, but releases now live under wasm-bindgen. The patch corrects the URL.

What Changed

  • patches/wasm-pack@0.14.0.patch: single-line patch changing the hardcoded author from drager to wasm-bindgen in the download URL
  • package.json: registers the patch under pnpm.patchedDependencies
  • pnpm-lock.yaml: updated consistently with the patched dependency hash
  • publish.yaml: cosmetic blank line removal (unrelated)

Feedback

Correctness -- the fix is correct. drager is the original author; the project transferred to the wasm-bindgen org, and release assets are no longer published under drager. The patch is minimal and precise.

Approach -- using patchedDependencies is the right call. Patching via pnpm is clean and reviewable; the lock file hash ensures the patch is stable and reproducible across installs.

Security -- this is an improvement. Pointing at the official wasm-bindgen org rather than a potentially stale fork reduces supply chain risk.

Minor issues:

  • The PR description is entirely unfilled. Please add a one-line summary explaining the root cause (wrong GitHub org in binary.js) so the history is searchable.
  • The blank line removal in publish.yaml is cosmetic and orthogonal.
  • No tests added -- acceptable for a CI/build tooling fix.
  • Consider adding a comment in package.json with the upstream issue link so the patch can be dropped when a fixed release ships.

Summary

The fix is correct and the approach is sound. The main ask is to fill out the PR description with the root cause.

@abcxff abcxff changed the title temp: fix wasm-pack fix: wasm-pack build May 13, 2026
@abcxff abcxff marked this pull request as ready for review May 13, 2026 17:39
@abcxff abcxff force-pushed the 05-06-fix_rivetkit_bind_methods_through_createwritethroughproxy branch from 6e0dfcb to ff912a6 Compare May 13, 2026 18:04
@abcxff abcxff force-pushed the 05-12-temp_fix_wasm-pack branch from 5f7bac7 to 24f24d7 Compare May 13, 2026 18:04
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5048 May 13, 2026 18:05 Destroyed
@abcxff abcxff force-pushed the 05-12-temp_fix_wasm-pack branch from 24f24d7 to cc6719f Compare May 13, 2026 18:31
@abcxff abcxff force-pushed the 05-06-fix_rivetkit_bind_methods_through_createwritethroughproxy branch from ff912a6 to 77e9b2f Compare May 13, 2026 18:31
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5048 May 13, 2026 18:32 Destroyed
@abcxff abcxff force-pushed the 05-06-fix_rivetkit_bind_methods_through_createwritethroughproxy branch 2 times, most recently from ce604d2 to 342a262 Compare May 13, 2026 18:48
@abcxff abcxff force-pushed the 05-12-temp_fix_wasm-pack branch from cc6719f to 211349e Compare May 13, 2026 18:48
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5048 May 13, 2026 18:48 Destroyed
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 13, 2026

PR Review: fix: wasm-pack build (#5048)

Overview

This PR downgrades wasm-pack from 0.14.0 to 0.13.1 and pins it via a pnpm workspace override to fix a wasm-pack build issue.


Code Quality

  • The change is minimal, focused, and correct. Using pnpm overrides to force a specific version across the monorepo is the right approach.
  • The =0.13.1 exact-version syntax is proper pnpm override notation and prevents accidental drift.
  • Lockfile is updated consistently.

Issues / Concerns

Missing PR description context
The PR template is completely unfilled — no explanation of what broke with 0.14.0, no reproduction steps, and no test description. This makes it impossible to assess whether the downgrade is a proper fix or a workaround. Please document:

  • What symptom was observed with 0.14.0 (error message, CI failure link, etc.)
  • Whether this is a known upstream regression in 0.14.0
  • Whether a tracking issue exists for eventually upgrading back to 0.14.0 or later

No tracking for the pin
Pinned dependency overrides can silently become stale. Consider adding a .agent/todo/ entry or an inline comment near the override noting why the pin exists and the condition for removing it (e.g. a link to the upstream wasm-pack issue).

Scope of override
The lockfile shows only rivetkit-typescript/packages/sql-loader directly depends on wasm-pack. The override is workspace-wide, which is fine since it forces consistent resolution, but worth confirming no other package currently on 0.14.0 is broken by the downgrade.


Risk Assessment

  • Low code risk: Pinning an exact older version is reversible and scoped to the build toolchain.
  • Medium process risk: Without a written rationale, future contributors may not know why this pin exists and may inadvertently remove it.

Summary

The mechanical change is correct. Main ask: fill in the PR description with what broke, a link to any upstream issue, and a note on when the pin can be removed. Recommend adding a .agent/todo/ entry or comment so the pin does not silently rot.

@abcxff abcxff changed the base branch from 05-06-fix_rivetkit_bind_methods_through_createwritethroughproxy to graphite-base/5048 May 13, 2026 19:11
@abcxff abcxff force-pushed the graphite-base/5048 branch from 342a262 to ec51340 Compare May 13, 2026 19:11
@abcxff abcxff force-pushed the 05-12-temp_fix_wasm-pack branch from 211349e to 24e1828 Compare May 13, 2026 19:11
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5048 May 13, 2026 19:11 Destroyed
@abcxff abcxff changed the base branch from graphite-base/5048 to 05-09-fix_workflow-engine_only_commit_step_state_after_success May 13, 2026 19:11
@abcxff abcxff changed the base branch from 05-09-fix_workflow-engine_only_commit_step_state_after_success to graphite-base/5048 May 13, 2026 20:07
@abcxff abcxff force-pushed the 05-12-temp_fix_wasm-pack branch from 24e1828 to 8f133bf Compare May 13, 2026 20:07
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5048 May 13, 2026 20:07 Destroyed
@abcxff abcxff changed the base branch from graphite-base/5048 to main May 13, 2026 20:07
@abcxff abcxff force-pushed the 05-12-temp_fix_wasm-pack branch from 8f133bf to 80c7cb9 Compare May 13, 2026 20:09
@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5048 May 13, 2026 20:09 Destroyed
Copy link
Copy Markdown
Contributor Author

abcxff commented May 13, 2026

Merge activity

  • May 13, 8:11 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 13, 8:12 PM UTC: @abcxff merged this pull request with Graphite.

@abcxff abcxff merged commit fe3ec94 into main May 13, 2026
12 of 13 checks passed
@abcxff abcxff deleted the 05-12-temp_fix_wasm-pack branch May 13, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant