DO NOT MERGE: queue diagnose

[abcxff]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[railway-app]

🚅 Deployed to the rivet-pr-5050 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
kitchen-sink	❌ Build Failed (View Logs)	Web	May 14, 2026 at 6:09 pm
frontend-cloud	❌ Build Failed (View Logs)	Web	May 13, 2026 at 8:19 pm
frontend-inspector	❌ Build Failed (View Logs)	Web	May 13, 2026 at 8:11 pm
ladle	❌ Build Failed (View Logs)	Web	May 12, 2026 at 5:53 pm
mcp-hub	✅ Success (View Logs)	Web	May 12, 2026 at 5:48 pm
website	❌ Build Failed (View Logs)	Web	May 12, 2026 at 5:47 pm

[abcxff]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(rivetkit): fix BigInt serialization in inspector workflow history and state deserialization #5058
• DO NOT MERGE: queue diagnose #5050 👈 (View in Graphite)
• [slop]fix(workflow-engine): only commit step state after success #5010 : 1 other dependent PR (#5052 )
• fix(rivetkit): bind methods through createWriteThroughProxy #4987
• fix(rivetkit): remove client-side connection request size check #5057
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review: DO NOT MERGE — Queue Diagnostics

Note: This is a draft diagnostic PR. Review focuses on issues that would need addressing before any production landing.

---

Overview

This PR adds temporary diagnostic instrumentation across the queue subsystem — tracing::warn! calls in Rust (queue.rs) and logger().debug / this.log("debug", ...) calls in TypeScript (native.ts, context.ts) — all prefixed with DEBUG_QUEUE to trace message flow through enqueue, next_batch, try_receive_batch, and list_message_entries.

---

Issues

Critical (before any merge)

• Wrong log level in Rust. Every diagnostic trace uses tracing::warn! instead of tracing::debug! or tracing::trace!. warn is reserved for actionable operational problems per the repo's logging conventions. Flooding warn-level telemetry with DEBUG_QUEUE messages will trigger alerts in production and make real warnings harder to spot. TypeScript counterparts correctly use debug level — Rust should match.

• Log messages violate casing convention. CLAUDE.md requires all log messages to be lowercase unless referencing a specific code symbol. Messages like "DEBUG_QUEUE enqueue_message: config" and "DEBUG_QUEUE try_receive_batch: listed messages" contain uppercase tokens that are not code symbols. If this ever graduates to permanent traces, they'll need to be lowercased.

Minor / Nitpick

• has_preload variable (around line 590 in queue.rs) is a correct and necessary fix — preload.is_some() must be captured before the value is moved into preload.as_ref(). This is a valid standalone improvement independent of the diagnostics.

• list_message_entries refactor — extracting entries into a local variable and returning it explicitly is slightly cleaner than the original chained .context() return. Worth keeping if this function is ever touched again.

• Structured fields are correct. All new Rust traces use named fields (metadata_size, will_reject, kv_message_count, etc.) rather than embedding values in the message string. That matches the project's tracing style.

---

Summary

The diagnostic intent is clear and the instrumentation covers the right call sites. Two changes are required before landing any part of this:

1. Replace all tracing::warn! with tracing::debug! (or tracing::trace! for the hot-path list_message_entries sites).
2. Lowercase all log messages.

The has_preload capture and the list_message_entries refactor are clean and could be extracted into a separate, mergeable commit.

[claude]

The existing review (comment 4433242763 from 2026-05-12) remains accurate after re-review on 2026-05-14. No code changes were made to the PR since the initial review. Key finding: all 7 Rust diagnostic log statements use tracing::warn! instead of tracing::debug! or tracing::trace!, which is the primary issue to fix before this branch influences any production-targeting code.