feat(inspector): insert and clear actor queue#5065
Conversation
|
🚅 Deployed to the rivet-pr-5065 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: feat(inspector): insert and clear actor queueSummaryThis PR adds inspector endpoints for queue management: Strengths
Issues1. Missing queue reset notifications 2. Missing validation on enqueue body 3. TypeScript type assertion (not narrowing) const body = await jsRequest.json() as { name?: string; body?: unknown };This is a Test CoverageThis PR is marked as DRAFT and has no tests. For inspector endpoints that manipulate actor state, tests should cover:
Blocking Concerns Before Merge
Non-blocking Observations
Overall this is a solid, well-structured implementation. The main blockers are test coverage and the queue name validation edge case. |
3b46462 to
a89784a
Compare
73cbe67 to
9dc7e20
Compare
a89784a to
95dd3b3
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: